Allow zoneHash to be passed in input to createOrder and createBulkOrders#308
Merged
ryanio merged 2 commits intoProjectOpenSea:mainfrom Jul 13, 2023
Merged
Allow zoneHash to be passed in input to createOrder and createBulkOrders#308ryanio merged 2 commits intoProjectOpenSea:mainfrom
zoneHash to be passed in input to createOrder and createBulkOrders#308ryanio merged 2 commits intoProjectOpenSea:mainfrom
Conversation
Collaborator
|
Lgtm, thanks for opening! Do you mind adding a test to ensure that the value is passed through correctly to the resulting retuned orders? Just so it won't break in the future in case code gets changed around. |
Contributor
Author
Sure thing! Will add it later today! |
Contributor
Author
|
Added a test case. Is this alright? Or do we require something more elaborate? I tested whether both |
|
@ryanio kindly bumping this |
ryanio
approved these changes
Jul 13, 2023
Collaborator
Contributor
|
Just what I needed. Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
zoneHashis a mechanism for contracts utilizing the SeaPort infra to pass along arbitrary values it should be able to be passed as part ofinputin the order creation methods.