Skip to content

Conversation

@jukent
Copy link
Contributor

@jukent jukent commented Jun 24, 2023

Thank you for your Cookbook contribution!

This PR follows the steps from this Google Doc on adding DOIs.

Link checks will fail on Zenodo badges until first release.

Please add or comment affiliations, ORCIDs, or github usernames for the authors of this book (this is optional).

@jukent jukent requested a review from negin513 June 24, 2023 14:40
@github-actions
Copy link

github-actions bot commented Jun 24, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 748dc66
✅ Deployment Preview URL: https://ProjectPythia.github.io/dask-cookbook/_preview/10

@negin513 negin513 merged commit 5b511e8 into ProjectPythia:main Jul 5, 2023
github-actions bot pushed a commit that referenced this pull request Jul 5, 2023
@negin513
Copy link
Collaborator

Hello @jukent ,
Thanks for creating this PR. I have noticed the DOI link does not work and the build fails due to this. I was wondering if you can help me adding correct DOI to this. I think I probably need to follow some steps to make sure the DOI is created correctly?

Thanks again for your help with all this.
Negin

@jukent
Copy link
Contributor Author

jukent commented Jul 17, 2023

Hi @negin513 I had to make a release on Zenodo, and now the badges work and shouldn't fail any link checks. Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants