Further Site Improvements on People Page #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 22, 2020 09:55
kmpaul
requested review from
brian-rose,
clyne,
dcamron,
dopplershift,
erogluorhan,
jukent and
ktyle
dopplershift
approved these changes
Dec 22, 2020
added 2 commits
December 22, 2020 15:56
brian-rose
reviewed
Dec 23, 2020
brian-rose
reviewed
Dec 23, 2020
brian-rose
reviewed
Dec 23, 2020
brian-rose
reviewed
Dec 23, 2020
brian-rose
reviewed
Dec 23, 2020
Member
brian-rose
left a comment
brian-rose
left a comment
There was a problem hiding this comment.
Sorry to be pedantic, but I noted several places where the text "University of Albany" should be changed to "University at Albany".
I know it's a weird name, but that's just how it is!
clyne
approved these changes
Dec 23, 2020
Collaborator
Author
|
Ah! Thanks. I'll fix that. |
Collaborator
Author
|
Ok. I believe that's now fixed. |
andersy005
approved these changes
Dec 23, 2020
brian-rose
reviewed
Dec 23, 2020
content/pages/people.md
Outdated
| - Matthew C. Long (NCAR) [[@matt-long](https://github.com/matt-long)] | ||
| - Ryan May (Unidata) [[@dopplershift](https://github.com/dopplershift)] | ||
| - Kevin Paul (NCAR) [[@kmpaul](https://github.com/kmpaul)] | ||
| - Brian E. J. Rose (University at Albany) [[@brian-rose](https://github.com/brian-rose])] |
Member
There was a problem hiding this comment.
There's an extra bracket here which is breaking the link.
Collaborator
Author
There was a problem hiding this comment.
Good catch! I missed that.
brian-rose
requested changes
Dec 23, 2020
Member
brian-rose
left a comment
brian-rose
left a comment
There was a problem hiding this comment.
All looks good except the broken link to my github
Collaborator
Author
|
Fixed. |
brian-rose
approved these changes
Dec 23, 2020
erogluorhan
reviewed
Dec 30, 2020
Member
erogluorhan
left a comment
erogluorhan
left a comment
There was a problem hiding this comment.
This looks good overall, though, I made a few inline comments about typos.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some additions and improvements to the Pythia Portal, mainly to the "People" page, but it also corrects an oversight in only listing the UCAR NSF award number on the main page. I added more names to the list of people on the Pythia Team page and I added GitHub usernames to those people on the list.
Let me know if you think this looks good!