Skip to content

Conversation

@idk3
Copy link
Collaborator

@idk3 idk3 commented Aug 31, 2017

No description provided.

@idk3
Copy link
Collaborator Author

idk3 commented Aug 31, 2017

@babbush this should fail (hopefully only) due to decreased test coverage from the unittest.skip - can you load it to yours and run it with the skip commented out?

@babbush
Copy link
Contributor

babbush commented Sep 1, 2017

Why? I'm not entirely sure what you are asking. Pull requests are to contribute code to the library. You should only contribute code that passes all the tests. Do you have something else in mind?

@idk3
Copy link
Collaborator Author

idk3 commented Sep 1, 2017

@damiansteiger do you know what might be causing this? My builds are all getting The command "pip$PY install -r requirements.txt" failed and exited with 1 during . in output.

@damiansteiger
Copy link
Contributor

It is due to a new pybind version (ProjectQ-Framework/ProjectQ#144)

Either wait for the fix or add a requirement to install the old pybind version before it installs ProjectQ.

@damiansteiger
Copy link
Contributor

The issue of pybind11 and ProjectQ is fixed in the new version 0.3.3

@idk3
Copy link
Collaborator Author

idk3 commented Sep 1, 2017

Thanks!!

Copy link
Contributor

@babbush babbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babbush babbush merged commit 38d18d8 into ProjectQ-Framework:develop Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants