⚖️ [Artifact 1227] オーロラサイスの移動速度バフを削除#1989
Merged
haiiro2gou merged 1 commit intomasterfrom May 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Artifact 1227「オーロラサイス」の最大チャージ時に付与されていた移動速度バフ(Effect 0317: aurora_speed)を削除し、関連するエフェクト定義/呼び出し/表示文言を整理するPRです。
Changes:
- Effect 0317 (aurora_speed) を effect の各種タグ(register/given/end/remove)から除外
- Effect 0317 の実装関数一式(register/given/end/remove と modifier add/remove)を削除
- Effect 0315 終了処理から「Stack==3 で Effect 317 付与」を削除し、神器Loreから速度バフ文言を削除
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Asset/data/asset/tags/functions/effect/remove.json | Effect 317 の remove 呼び出しをタグから除外 |
| Asset/data/asset/tags/functions/effect/register.json | Effect 317 の register 呼び出しをタグから除外 |
| Asset/data/asset/tags/functions/effect/given.json | Effect 317 の given 呼び出しをタグから除外 |
| Asset/data/asset/tags/functions/effect/end.json | Effect 317 の end 呼び出しをタグから除外 |
| Asset/data/asset/functions/effect/0317.aurora_speed/remove/.mcfunction | Effect 317 remove 時処理の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/register.mcfunction | Effect 317 定義(register本体)の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/modifier/remove.mcfunction | Effect 317 の移動速度modifier除去処理の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/modifier/add.mcfunction | Effect 317 の移動速度modifier付与処理の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/given/.mcfunction | Effect 317 given 時処理の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/end/.mcfunction | Effect 317 end 時処理の削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/_/remove.mcfunction | Effect 317 remove ディスパッチの削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/_/register.mcfunction | Effect 317 register ディスパッチの削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/_/given.mcfunction | Effect 317 given ディスパッチの削除 |
| Asset/data/asset/functions/effect/0317.aurora_speed/_/end.mcfunction | Effect 317 end ディスパッチの削除 |
| Asset/data/asset/functions/effect/0315.charge_of_aurora_scythe/end/.mcfunction | Stack==3 時の Effect 317 付与を削除 |
| Asset/data/asset/functions/artifact/1227.aurora_scythe/give/2.give.mcfunction | 神器Loreから移動速度+10%の文言を削除 |
Comments suppressed due to low confidence (1)
Asset/data/asset/functions/effect/0315.charge_of_aurora_scythe/end/.mcfunction:17
- エフェクト317(aurora_speed)の付与処理を削除しているため、データパック更新の瞬間に既に移動速度modifier(UUID: 00000001-0000-0003-0000-013d00000000)が付いていたプレイヤーがいた場合、end/removeハンドラも削除済みで回収されず恒久的に残る可能性があります。対策として、ロード時/移行用functionで当該UUIDのmovement_speed modifierを@Aから一括削除する等のクリーンアップを追加してください。
data modify storage api: Argument.FieldOverride.Damage set from storage asset:context this.Damage
data modify storage api: Argument.FieldOverride.AdditionalMPHeal set from storage asset:context this.AdditionalMPHeal
function api:entity/mob/effect/give
function api:entity/mob/effect/reset
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haiiro2gou
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
調整班の許可は貰っている