🚸 MessageLibの神器の使用不可メッセージにクールダウンを設定#2270
Merged
Merged
Conversation
EllaCoat
requested changes
May 30, 2026
EllaCoat
approved these changes
May 30, 2026
EllaCoat
left a comment
EllaCoat
left a comment
Member
There was a problem hiding this comment.
コード的には大丈夫。
設計判断は任せました、マージ担当者よ。
Contributor
There was a problem hiding this comment.
Pull request overview
神器使用失敗時に表示されるメッセージ(lib:message/artifact/*)が連打されると煩いため、プレイヤー単位で20ティックのクールダウンを設けて抑制する変更です。各メッセージ関数に同型のクールダウン処理を追加し、対応するスコアボードオブジェクティブを core:load_once で登録しています。
Changes:
- 3つのメッセージ関数 (
can_not_use_here/condition_not_met/dont_have_require_items) にstorage global Timeと@s ...LatestLogTickの差分による20tクールダウン判定を追加。 - 上記で使用する
CannotUseHereLatestLogTick/ConditionNotMetLatestLogTick/DontHaveRequiredItemsLatestLogTickの3つの dummy objective をload_once.mcfunctionで登録。
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TheSkyBlessing/data/lib/functions/message/artifact/can_not_use_here.mcfunction | tellraw を20tクールダウンでガード。前回ログ時刻を CannotUseHereLatestLogTick に保存。 |
| TheSkyBlessing/data/lib/functions/message/artifact/condition_not_met.mcfunction | 同上、ConditionNotMetLatestLogTick を使用。 |
| TheSkyBlessing/data/lib/functions/message/artifact/dont_have_require_items.mcfunction | 同上、DontHaveRequiredItemsLatestLogTick を使用。 |
| TheSkyBlessing/data/core/functions/load_once.mcfunction | 上記3つの dummy objective を登録。 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haiiro2gou
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
トースター作ってて喧しいと思ったため
ずっと前にSina-TK作ってた時にはいいろ氏がやろうとしてた気がする