Skip to content

Conversation

@avirajsingh7
Copy link
Collaborator

@avirajsingh7 avirajsingh7 commented Jun 24, 2025

Purpose of This PR

Since adding logs across all files at once made the PR too large and hard to review, this PR includes logs only for a subset of endpoints as a first step.

Plan

  • This PR targets a main.
  • Additional endpoints will be instrumented in follow-up PRs to this branch.

This PR Includes

Logging for the following endpoints:

  • Documents
  • API Key
  • Collection
  • And for Open AI and AWS services

@avirajsingh7 avirajsingh7 changed the base branch from enhancement/logs to main June 24, 2025 09:09
@codecov
Copy link

codecov bot commented Jun 24, 2025

@avirajsingh7 avirajsingh7 self-assigned this Jun 26, 2025
@avirajsingh7 avirajsingh7 added the enhancement New feature or request label Jun 26, 2025
@avirajsingh7 avirajsingh7 moved this to In Progress in Dev Priorities Jun 26, 2025
This was linked to issues Jun 26, 2025
@vijay-T4D vijay-T4D requested a review from nishika26 June 27, 2025 07:29
Copy link
Collaborator

@vijay-T4D vijay-T4D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current logging implementation looks good. lets review the logs and fine tune accordingly

)
if not credentials or "api_key" not in credentials:
logger.error(
logger.warning(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be a warning or an error, because if we won't have an openai key, the endpoint won't work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be a error

@AkhileshNegi AkhileshNegi merged commit fefc02f into main Jun 27, 2025
1 check passed
@AkhileshNegi AkhileshNegi deleted the fix/logging branch June 27, 2025 08:02
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Dev Priorities Jun 27, 2025
This was unlinked from issues Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-review

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Review and Add structured logging to API Key, Collection and Document Routes

4 participants