-
Couldn't load subscription status.
- Fork 5
Added logs for API Key, Collection and Documents Endpoint #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current logging implementation looks good. lets review the logs and fine tune accordingly
| ) | ||
| if not credentials or "api_key" not in credentials: | ||
| logger.error( | ||
| logger.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be a warning or an error, because if we won't have an openai key, the endpoint won't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be a error
Purpose of This PR
Since adding logs across all files at once made the PR too large and hard to review, this PR includes logs only for a subset of endpoints as a first step.
Plan
This PR Includes
Logging for the following endpoints: