Skip to content

Mask assistant_id in Response API Logs #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Mask assistant_id in Response API Logs #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions backend/app/api/routes/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from app.crud.assistants import get_assistant_by_id
from app.crud.credentials import get_provider_credential
from app.models import UserOrganization
from app.utils import APIResponse
from app.utils import APIResponse, mask_string
from app.core.langfuse.langfuse import LangfuseTracer

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -104,7 +104,7 @@ def process_response(
):
"""Process a response and send callback with results, with Langfuse tracing."""
logger.info(
f"Starting generating response for assistant_id={request.assistant_id}, project_id={request.project_id}"
f"Starting generating response for assistant_id={mask_string(request.assistant_id)}, project_id={request.project_id}"
)

tracer.start_trace(
Expand Down Expand Up @@ -143,7 +143,7 @@ def process_response(
response_chunks = get_file_search_results(response)

logger.info(
f"Successfully generated response: response_id={response.id}, assistant={request.assistant_id}, project_id={request.project_id}"
f"Successfully generated response: response_id={response.id}, assistant={mask_string(request.assistant_id)}, project_id={request.project_id}"
)

tracer.end_generation(
Expand Down Expand Up @@ -197,11 +197,11 @@ def process_response(

if request.callback_url:
logger.info(
f"Sending callback to URL: {request.callback_url}, assistant={request.assistant_id}, project_id={request.project_id}"
f"Sending callback to URL: {request.callback_url}, assistant={mask_string(request.assistant_id)}, project_id={request.project_id}"
)
send_callback(request.callback_url, callback_response.model_dump())
logger.info(
f"Callback sent successfully, assistant={request.assistant_id}, project_id={request.project_id}"
f"Callback sent successfully, assistant={mask_string(request.assistant_id)}, project_id={request.project_id}"
)


Expand All @@ -214,15 +214,15 @@ async def responses(
):
"""Asynchronous endpoint that processes requests in background with Langfuse tracing."""
logger.info(
f"Processing response request for assistant_id={request.assistant_id}, project_id={request.project_id}, organization_id={_current_user.organization_id}"
f"Processing response request for assistant_id={mask_string(request.assistant_id)}, project_id={request.project_id}, organization_id={_current_user.organization_id}"
)

assistant = get_assistant_by_id(
_session, request.assistant_id, _current_user.organization_id
)
if not assistant:
logger.warning(
f"Assistant not found: assistant_id={request.assistant_id}, project_id={request.project_id}, organization_id={_current_user.organization_id}",
f"Assistant not found: assistant_id={mask_string(request.assistant_id)}, project_id={request.project_id}, organization_id={_current_user.organization_id}",
)
raise HTTPException(status_code=404, detail="Assistant not found or not active")

Expand Down Expand Up @@ -265,7 +265,7 @@ async def responses(
)

logger.info(
f"Background task scheduled for response processing: assistant_id={request.assistant_id}, project_id={request.project_id}, organization_id={_current_user.organization_id}"
f"Background task scheduled for response processing: assistant_id={mask_string(request.assistant_id)}, project_id={request.project_id}, organization_id={_current_user.organization_id}"
)

return {
Expand Down