-
Notifications
You must be signed in to change notification settings - Fork 10
Webhook: Add Fingerprinting to Webhook Payloads #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e84c2fd
43a717d
ac0e083
22affb9
bdd5f0b
6add65b
788a1f0
c96dad4
3b73458
d14a59e
3d31b76
c554cab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ class Provider(str, Enum): | |
| GOOGLE = "google" | ||
| SARVAMAI = "sarvamai" | ||
| ELEVENLABS = "elevenlabs" | ||
| WEBHOOK_SECRET = "webhook_secret" | ||
|
|
||
|
|
||
| @dataclass | ||
|
|
@@ -42,6 +43,9 @@ class ProviderConfig: | |
| Provider.ELEVENLABS: ProviderConfig( | ||
| required_fields=["api_key"], sensitive_fields=["api_key"] | ||
| ), | ||
| Provider.WEBHOOK_SECRET: ProviderConfig( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. update the credentials endpoint doc .. |
||
| required_fields=["webhook_secret"], sensitive_fields=["webhook_secret"] | ||
| ), | ||
|
Comment on lines
+46
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update credential tests that hardcode the provider set. Adding 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the webhook credential examples.
The multi-provider JSON is invalid (
"webhook_secret: ...is missing the closing key quote), and the standalone example uses a different shape than the provider-object format. This will mislead API users.📝 Proposed fix
"langfuse": { "public_key": "pk-lf-....", "secret_key": "sk-lf-...", "host": "https://cloud.langfuse.com" }, "webhook_secret": { - "webhook_secret: "webhook_secret" - }, + "webhook_secret": "your-webhook-secret" + } } }For registering Webhook Secret
{ - "credential":{ - "webhook_secret":"your-webhook-secret" + "credential": { + "webhook_secret": { + "webhook_secret": "your-webhook-secret" + } } - }Verify each finding against the current code and only fix it if needed.
In
@backend/app/api/docs/credentials/create.mdaround lines 45 - 58, Theexamples for webhook credentials are invalid and inconsistent: fix the
multi-provider JSON by closing the missing quote on the "webhook_secret" key and
nesting the provider object under "credential" so it matches the provider-object
shape (i.e., "credential": { "webhook_secret": { "webhook_secret": "..." } }),
and update the standalone "For registering Webhook Secret" example to use the
same object shape (credential -> webhook_secret -> webhook_secret) so both
examples are valid JSON and consistent; key symbols to locate are the
"credential" object and the "webhook_secret" key in the shown examples.