Skip to content

Docker: Hotfix ENV variable#781

Merged
AkhileshNegi merged 1 commit intomainfrom
fix/update-docker-build
Apr 22, 2026
Merged

Docker: Hotfix ENV variable#781
AkhileshNegi merged 1 commit intomainfrom
fix/update-docker-build

Conversation

@Ayush8923
Copy link
Copy Markdown
Collaborator

@Ayush8923 Ayush8923 commented Apr 22, 2026

Summary

  • Removed hardcoded POSTGRES_SERVER: db override from prestart, backend, celery_worker, and celery_flower services in docker-compose.yml.
  • Services now inherit POSTGRES_SERVER from .env via env_file, allowing the same compose file to target either the local db container or a remote host (e.g. RDS) by simply changing .env.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

@Ayush8923 Ayush8923 self-assigned this Apr 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

📝 Walkthrough

Walkthrough

The POSTGRES_SERVER: db environment variable was removed from four services in docker-compose.yml: prestart, backend, celery_worker, and celery_flower. No other configuration, commands, dependencies, or services were modified.

Changes

Cohort / File(s) Summary
Docker Configuration
docker-compose.yml
Removed POSTGRES_SERVER: db environment variable from prestart, backend, celery_worker, and celery_flower services.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A variable vanished without a trace,
Four services freed from that database place,
The config grew lighter, the compose file so clean,
Environment variables, no longer seen!
Hop hop, the cleanup is done! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing hardcoded POSTGRES_SERVER values from docker-compose.yml to inherit from .env instead.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-docker-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Ayush8923 Ayush8923 requested a review from AkhileshNegi April 22, 2026 12:14
@Ayush8923 Ayush8923 changed the title Build: Docker Build Fixes Build: Inherit POSTGRES_SERVER from .env instead of hardcoding to db Apr 22, 2026
@AkhileshNegi AkhileshNegi merged commit 7135ec2 into main Apr 22, 2026
3 checks passed
@AkhileshNegi AkhileshNegi deleted the fix/update-docker-build branch April 22, 2026 12:33
@Ayush8923 Ayush8923 changed the title Build: Inherit POSTGRES_SERVER from .env instead of hardcoding to db Build: use POSTGRES_SERVER from .env Apr 22, 2026
@Ayush8923 Ayush8923 changed the title Build: use POSTGRES_SERVER from .env Docker: Hotfix ENV variable Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants