Skip to content

Temperature: Config temperature fix, now able to set to 0#46

Merged
vprashrex merged 5 commits intomainfrom
fix/config-llm-temperature
Feb 26, 2026
Merged

Temperature: Config temperature fix, now able to set to 0#46
vprashrex merged 5 commits intomainfrom
fix/config-llm-temperature

Conversation

@vprashrex
Copy link
Collaborator

@vprashrex vprashrex commented Feb 26, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Preserve explicit 0 temperature values so they no longer fall back to the default 0.7.
  • Style

    • Temperature control now displays two decimal places, supports finer adjustments (smaller step), a higher maximum range, and simplified helper labels for clarity.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c7e580 and 349d9ce.

📒 Files selected for processing (1)
  • app/components/prompt-editor/ConfigEditorPane.tsx

📝 Walkthrough

Walkthrough

Replaced logical-OR defaulting with nullish coalescing for temperature in three files; UI temperature input/display precision and range were adjusted.

Changes

Cohort / File(s) Summary
Temperature handling & UI
app/components/SimplifiedConfigEditor.tsx, app/components/prompt-editor/ConfigEditorPane.tsx, app/lib/useConfigs.ts
Replaced `params.temperature

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 A zero hopped out from the nudge,
No longer folded by a fudge.
Nullish gave it rightful place,
Two decimals, gentle grace. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing temperature config to allow setting it to 0, which is the core issue addressed across all three modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/config-llm-temperature

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vprashrex vprashrex merged commit 2d50a88 into main Feb 26, 2026
1 check was pending
@Ayush8923 Ayush8923 deleted the fix/config-llm-temperature branch March 20, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant