Docker: Remove Postgres#51
Conversation
📝 WalkthroughWalkthroughThe pull request removes standalone database ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker-compose.yml (1)
29-36:⚠️ Potential issue | 🔴 CriticalPort mismatch prevents the backend service from functioning: uvicorn listens on port 80 but port mapping and healthcheck expect port 8000.
The
commandon line 36 starts uvicorn with--port 80, but:
- Line 29 maps
8001:8000(host 8001 → container port 8000)- Line 31 healthcheck probes
localhost:8000No process will be listening on container port 8000, causing the healthcheck to fail and the service to be inaccessible. This is a critical configuration error.
Fix by changing uvicorn to listen on port 8000 (the intended port based on the default
fastapi runbehavior in entrypoint.sh):command: > - uv run uvicorn app.main:app --host 0.0.0.0 --port 80 --reload + uv run uvicorn app.main:app --host 0.0.0.0 --port 8000 --reload
Summary
Target issue is #50
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Summary by CodeRabbit