Skip to content

Docker: Remove Postgres#51

Merged
AkhileshNegi merged 3 commits intomainfrom
enhancement/docker-updates
Feb 16, 2026
Merged

Docker: Remove Postgres#51
AkhileshNegi merged 3 commits intomainfrom
enhancement/docker-updates

Conversation

@AkhileshNegi
Copy link
Copy Markdown
Collaborator

@AkhileshNegi AkhileshNegi commented Feb 16, 2026

Summary

Target issue is #50
Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Summary by CodeRabbit

  • Chores
    • Simplified deployment configuration by removing unnecessary services.
    • Adjusted backend service port mapping to 8001.

@AkhileshNegi AkhileshNegi self-assigned this Feb 16, 2026
@AkhileshNegi AkhileshNegi linked an issue Feb 16, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 16, 2026

📝 Walkthrough

Walkthrough

The pull request removes standalone database (db) and admin (adminer) services from Docker Compose configuration, eliminates related service dependencies, and updates the backend service to use host.docker.internal for connectivity. Port mapping for the backend is adjusted from 8000 to 8001 on the host.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yml
Removed db and adminer top-level services; removed depends_on references and related health/restart policies from prestart and backend services; added extra_hosts: host.docker.internal to reach external services; changed backend host port from 8000 to 8001; reduced backend healthcheck timeout to 5s; removed app-db-data volume definition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • Docker: Remove Postgres #50: Addresses the same architectural pattern of removing standalone Postgres database services from Docker Compose and updating service dependencies accordingly.

Poem

🐰 Services stripped down, lean and light,
host.docker.internal shines so bright,
No more db chains, dependencies gone,
Docker compose hops forward at dawn! 🚀

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Docker: Remove Postgres' accurately reflects the main change: removal of PostgreSQL-related services (db and adminer) from docker-compose.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enhancement/docker-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docker-compose.yml (1)

29-36: ⚠️ Potential issue | 🔴 Critical

Port mismatch prevents the backend service from functioning: uvicorn listens on port 80 but port mapping and healthcheck expect port 8000.

The command on line 36 starts uvicorn with --port 80, but:

  • Line 29 maps 8001:8000 (host 8001 → container port 8000)
  • Line 31 healthcheck probes localhost:8000

No process will be listening on container port 8000, causing the healthcheck to fail and the service to be inaccessible. This is a critical configuration error.

Fix by changing uvicorn to listen on port 8000 (the intended port based on the default fastapi run behavior in entrypoint.sh):

     command: >
-      uv run uvicorn app.main:app --host 0.0.0.0 --port 80 --reload
+      uv run uvicorn app.main:app --host 0.0.0.0 --port 8000 --reload

@AkhileshNegi AkhileshNegi enabled auto-merge (squash) February 16, 2026 11:39
@AkhileshNegi AkhileshNegi merged commit 3d1b2a1 into main Feb 16, 2026
2 checks passed
@AkhileshNegi AkhileshNegi deleted the enhancement/docker-updates branch February 16, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker: Remove Postgres

2 participants