Fixes use of Val(), faster trim_time!(), and threaded one time expressions #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 14 14
Lines 31243 31252 +9
=======================================
+ Hits 13674 13678 +4
- Misses 17569 17574 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This patch replaces the `Val{:symbol}` dispatch in
`IMASdd.get_expressions` with `get_(dynamic|onetime)_expressions`.
Instead of defining new methods for `get_expressions` IMAS.jl will
explicitly register its global data structure using
`IMASdd.set_(dynamic|onetime)_expressions`.
The benefit of this restructure is that compilation of IMASdd becomes
independent of methods defined in IMAS. Before, after loading IMAS, a
lot of code in IMASdd had to be recompiled to take the new methods into
account.
Before:
```
julia> using IMASdd
julia> @time @eval IMASdd.dd();
0.004902 seconds (20.73 k allocations: 864.656 KiB, 34.05% compilation time)
julia> using IMAS
julia> @time @eval IMAS.dd();
7.673864 seconds (25.65 M allocations: 1.304 GiB, 3.21% gc time, 99.97% compilation time: 100% of which was recompilation)
```
After:
```
julia> using IMASdd
julia> @time @eval IMASdd.dd();
0.002903 seconds (20.73 k allocations: 864.656 KiB, 55.30% compilation time)
julia> using IMAS
julia> @time @eval IMAS.dd();
0.001035 seconds (20.69 k allocations: 863.375 KiB)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.