Merged
Conversation
felicityin
force-pushed
the
fix-issue
branch
from
75a5c58 to
1db0146
Compare
felicityin
force-pushed
the
fix-issue
branch
2 times, most recently
from
3f58354 to
d831156
Compare
eigmax
reviewed
Dec 11, 2025
| let len = u32::from_be_bytes(len_bytes) as usize; | ||
|
|
||
| if buf.len() != 4 + 2 * len { | ||
| tracing::error!("FpOp: Invalid buffer length"); |
Contributor
Author
There was a problem hiding this comment.
This makes it easier to locate the error, since the same exception is thrown in several places.
Member
There was a problem hiding this comment.
Define difference ExecutionError. The user can not access the proof network's log.
|
|
||
| /// The execution failed while converting a slice to an array. | ||
| #[error("failed to convert slice {0} to array")] | ||
| IntoArrayError(String), |
Member
There was a problem hiding this comment.
Can we receive an Error here? so we can construct IntoArrayError with any error instance.
Contributor
Author
There was a problem hiding this comment.
No, because core::array::TryFromSliceError does not implement the Serialize trait.
| ) -> Result<AffinePoint<E>, CurveError> { | ||
| let computed_point = k256::AffinePoint::decompress(bytes_be.into(), Choice::from(sign as u8)) | ||
| .into_option() | ||
| .ok_or_else(|| CurveError::InvalidAffinePoint(bytes_be.to_vec(), sign))?; |
Member
There was a problem hiding this comment.
We try not to do any type conversion when raising an error.
Contributor
Author
There was a problem hiding this comment.
There doesn't seem to be a better way here.
eigmax
pushed a commit
that referenced
this pull request
Dec 21, 2025
* fix: panic prone code in hook.rs * fix: panic prone code in events/precompiles/ec.rs * fix: panic prone code in traces generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.