fix: clarify Poseidon2 AIR memory-only comments#404
Merged
eigmax merged 2 commits intoProjectZKM:mainfrom Jan 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Poseidon2 skinny and wide AIR modules to remove misleading “only memory constraints” wording. The comments now describe that the chips enforce both the permutation rounds and the memory argument, and the in-function notes around send_single clarify that they specifically encode the memory argument for state/input/output words. No functional changes were made, only documentation-level corrections for better readability and to match the actual constraints enforced.