Skip to content

chore(primitives): deprecate Buffer::head#411

Merged
eigmax merged 1 commit intoProjectZKM:mainfrom
SashaMalysehko:chore/deprecate-buffer-head
Jan 10, 2026
Merged

chore(primitives): deprecate Buffer::head#411
eigmax merged 1 commit intoProjectZKM:mainfrom
SashaMalysehko:chore/deprecate-buffer-head

Conversation

@SashaMalysehko
Copy link
Contributor

Buffer::head is not used anywhere in the current codebase and is not part of any documented workflow. Marking it as deprecated keeps the public API technically intact while signalling that the method will be removed in a future release, reducing dead API surface without breaking existing users immediately.

@eigmax eigmax merged commit eb9a5d3 into ProjectZKM:main Jan 10, 2026
eigmax added a commit that referenced this pull request Jan 11, 2026
@eigmax
Copy link
Member

eigmax commented Jan 11, 2026

I reverted this, since ZKMPublicValues is not exposing head function.

However, it's necessary to expose head in ZKMPublicValues, for example, when we call read from ZKMPublicValues, we actually move the ptr to the head of the buffer, and then we can not use the buffer again.

eigmax added a commit that referenced this pull request Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants