Shankara/picus backend#442
Merged
eigmax merged 32 commits intoProjectZKM:pre-release-v1.2.5from Mar 11, 2026
Merged
Conversation
felicityin
reviewed
Feb 10, 2026
felicityin
approved these changes
Feb 24, 2026
shankarapailoor
force-pushed
the
shankara/picus-backend
branch
from
970f5ad to
f19fbd1
Compare
shankarapailoor
force-pushed
the
shankara/picus-backend
branch
from
2221154 to
434b6a8
Compare
eigmax
reviewed
Mar 11, 2026
| .when(local.is_branching) | ||
| .assert_word_eq(local.target_pc, local.next_next_pc); | ||
|
|
||
| builder.when(is_real.clone()).assert_eq( |
Member
There was a problem hiding this comment.
This is redundant.
In the CPU chip, we already have:
builder
.when_first_row()
.when_not(local.is_halt)
.assert_eq(local.pc + AB::Expr::from_canonical_u32(4), local.next_pc);
In current chip, local.next_pc is constrained by line 119 from the previous row.
Contributor
Author
There was a problem hiding this comment.
thanks yeah i forgot to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Picus backend for Ziren which allows developers to check the determinism of their circuits with Picus