fix humidity setters to handle unexpected data#62
Merged
Prominence merged 1 commit intoProminence:masterfrom Feb 9, 2026
Merged
fix humidity setters to handle unexpected data#62Prominence merged 1 commit intoProminence:masterfrom
Prominence merged 1 commit intoProminence:masterfrom
Conversation
|
@Prominence my colleague made the fix |
Owner
|
I'll release a new version soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix humidity to handle unexpected data
it may happen that as a result of current weather api call we get humidity data such as this one (more than 100)
previous implementation was throwing an exception which does not allow clients of the library to handle it gracefully
the PR suggests to round the data to min 0 or max 100