Fix duplicate React keys in library list#8
Merged
Conversation
added 4 commits
May 2, 2026 21:41
- Revert incorrect Audible username-based login flow for DE - Restore standard Amazon OAuth flow for all locales - Add missing BR locale to Rust core - Add amazon.com.br domain mapping - Fix incorrect marketplace IDs (DE, BR)
This PR depends on the DE/BR locale PR. Activation bytes are required for DRM/decryption, but they should not block OAuth login or account setup. This change skips activation byte retrieval during login so the login flow can complete after successful token exchange. Tested: - DE login succeeds - token exchange succeeds - login no longer aborts on activation bytes failure
- Allow the plans field to be null in Audible API responses - Prevent library sync from failing on nullable plans data
- Include list index in FlatList key - Prevent duplicate key warnings when duplicate ids are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on the previous library fix #7.
The library list can produce duplicate keys when multiple items share the same id.
This change ensures unique keys by combining id (or product id) with the list index.
Tested: