refactor: collapse mcp surface to ledgerr tools by elasticdotventures · Pull Request #27 · PromptExecution/ledgrrr

elasticdotventures · 2026-04-16T21:31:40Z

Summary

Collapse the advertised MCP surface from 28 tools to 7 top-level ledgerr_* capabilities while keeping the major domain areas visible:

ledgerr_documents
ledgerr_review
ledgerr_reconciliation
ledgerr_workflow
ledgerr_audit
ledgerr_tax
ledgerr_ontology

What changed

moved published tool discovery to the reduced 7-tool surface
switched the public namespace from l3dg3rr_* to ledgerr_*
relocated plugin operations under ledgerr_workflow via action: "plugin_info"
kept older l3dg3rr_* and proxy-style names as hidden compatibility aliases in server dispatch
updated MCP adapter schemas, server dispatch, outcome flow, tests, docs, and scripts
recorded the new surface rule in AGENTS.md

Validation

cargo test -p ledgerr-mcp
just test

Closes #19

Related follow-on gaps:

Copilot

Pull request overview

Refactors the MCP server’s advertised tool surface into a reduced set of 7 top-level ledgerr_* tools with action-based subcommands, while keeping legacy l3dg3rr_*/proxy tool names as hidden compatibility aliases.

Changes:

Collapses the MCP tool catalog to 7 ledgerr_* capability families and routes calls via action dispatch in the adapter/server.
Updates e2e tests and demo scripts to use the new ledgerr_* tool names and action arguments.
Refreshes operator docs/runbooks to reflect the reduced catalog and new invocation patterns.

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
scripts/mcp_e2e.sh	Updates the e2e script to run tests from the renamed crate/package.
scripts/mcp_cli_demo.sh	Updates demo calls to the new `ledgerr_*` tools and action-based arguments.
docs/mcp-capability-contract.md	Rewrites MCP surface documentation to reflect the reduced 7-tool catalog and compatibility notes.
docs/claude-cowork-plugin-marketplace.md	Updates marketplace/runtime docs and example `tools/call` usage for the new surface.
docs/agent-mcp-runbook.md	Simplifies the runbook and updates examples/test commands for the new tool surface.
crates/ledgerr-mcp/tests/*	Updates MCP e2e/contract tests to validate the reduced advertised catalog and new tool names.
crates/ledgerr-mcp/src/mcp_adapter.rs	Implements grouped tools (`ledgerr_*`) with `action` dispatch and updates tool catalog/schema generation.
crates/ledgerr-mcp/src/bin/mcp-outcome-test.rs	Updates the outcome-test flow to the new tool names/action arguments.
crates/ledgerr-mcp/src/bin/ledgerr-mcp-server.rs	Routes `tools/call` to the new grouped tools while preserving legacy aliases.
README.md	Updates README language to describe the reduced 7-tool MCP surface.
AGENTS.md	Documents the new “published surface rule” and updates canonical contract path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T21:35:46Z

+        WORKFLOW_TOOL => json!({
            "type": "object",
-            "required": ["state_marker"],
+            "required": ["action"],
            "properties": {
-                "state_marker": { "type": "string" }
+                "action": {


ledgerr_workflow schema requires only action, but transition and resume calls require additional mandatory fields (target_state/target_substate and state_marker respectively). Please make the schema action-sensitive (e.g., oneOf per action) so callers can discover the true required arguments via tools/list.

Copilot · 2026-04-16T21:35:46Z

 - Marketplace catalog: [marketplace.json](/home/brianh/promptexecution/mbse/l3dg3rr/.claude-plugin/marketplace.json)
 - Plugin manifest: [plugin.json](/home/brianh/promptexecution/mbse/l3dg3rr/plugins/l3dg3rr-plugin-create/.claude-plugin/plugin.json)
 - Plugin skill: [SKILL.md](/home/brianh/promptexecution/mbse/l3dg3rr/plugins/l3dg3rr-plugin-create/skills/plugin-create-for-l3dg3rr/SKILL.md)
- MCP server entrypoint: [turbo-mcp-server.rs](/home/brianh/promptexecution/mbse/l3dg3rr/crates/turbo-mcp/src/bin/turbo-mcp-server.rs)
+- MCP server entrypoint: [ledgerr-mcp-server.rs](/mnt/c/users/wendy/l3dg3rr/crates/ledgerr-mcp/src/bin/ledgerr-mcp-server.rs)
 - Runtime helper commands: [Justfile](/home/brianh/promptexecution/mbse/l3dg3rr/Justfile)


This markdown link points to a developer-specific absolute path (/mnt/c/users/wendy/...), which will be broken for other users and in GitHub rendering. Please switch to a repository-relative link (e.g., crates/ledgerr-mcp/src/bin/ledgerr-mcp-server.rs) like the other docs in the repo.

Copilot · 2026-04-16T21:35:46Z

+        DOCUMENTS_TOOL => json!({
            "type": "object",
-            "required": ["pdf_path", "journal_path", "workbook_path"],
+            "required": ["action"],
            "properties": {
+                "action": {
+                    "type": "string",
+                    "enum": ["list_accounts", "get_raw_context", "pipeline_status", "validate_filename", "ingest_pdf", "ingest_rows"]
+                },


tool_input_schema for ledgerr_documents only requires action, but the handler/parsers require additional fields depending on the action (e.g., ingest_pdf needs pdf_path/journal_path/workbook_path; ingest_rows needs rows). Please update the schema to reflect action-specific required arguments (e.g., via oneOf branches per action) so tools/list is code-aligned and clients can validate inputs before calling.

Copilot · 2026-04-16T21:35:47Z

                    "items": {
                        "type": "object",
-                        "required": ["account_id", "date", "amount", "description", "source_ref"],
+                        "required": ["date", "amount", "description", "source_ref"],


Schema for rows items does not require account_id/account, but parse_rows will error unless one of those fields is present. The schema should enforce this (e.g., require account_id or use anyOf to require either account_id or account) to avoid advertising an input shape that is guaranteed to fail at runtime.

Suggested change

"required": ["date", "amount", "description", "source_ref"],

"required": ["date", "amount", "description", "source_ref"],

"anyOf": [

{ "required": ["account_id"] },

{ "required": ["account"] }

],

Copilot · 2026-04-16T21:35:47Z

+        TAX_TOOL => json!({
            "type": "object",
-            "required": ["ontology_path", "from_entity_id", "reconciliation"],
+            "required": ["action"],
            "properties": {


ledgerr_tax schema only requires action, but assist/ambiguity_review parsing requires ontology_path, from_entity_id, and a nested reconciliation object. This schema/API mismatch will cause clients using tools/list schemas to produce invalid calls. Consider using oneOf with action-specific required fields (and making reconciliation required for the actions that need it).

Copilot · 2026-04-16T21:35:47Z

            "type": "object",
-            "required": ["path", "entities"],
+            "required": ["action", "ontology_path"],
            "properties": {
-                "path": { "type": "string" },
+                "action": { "type": "string", "enum": ["query_path", "export_snapshot", "upsert_entities", "upsert_edges"] },
+                "ontology_path": { "type": "string" },


ledgerr_ontology schema globally requires ontology_path but does not require from_entity_id for the query_path action, even though parse_ontology_query_path_request requires it. This should be reflected in the schema (e.g., oneOf per action) to prevent clients from generating calls that will deterministically fail.

…cture Merges origin/main (PRs #27-#30: MCP surface collapse, codegen contract, workbook export, persist state) into codex-issue-23-document-queue. Resolution strategy: - Keep origin/main's 7-tool contract architecture throughout - Retain document inventory helpers (lib.rs) and service call path - Add DocumentInventory as a new action variant in DocumentsArgs so document_inventory is now reachable as ledgerr_documents + action - Add handle_document_inventory + parse helpers to mcp_adapter.rs - Update PUBLISHED_TOOLS actions list and mcp-capability-contract.md to include document_inventory in the ledgerr_documents row All 41 test suites pass including contract_codegen schema/doc drift checks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: collapse mcp surface to ledgerr tools

5472ead

Copilot AI review requested due to automatic review settings April 16, 2026 21:31

Copilot started reviewing on behalf of elasticdotventures April 16, 2026 21:32 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

elasticdotventures merged commit 2c5ade7 into main Apr 17, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: collapse mcp surface to ledgerr tools#27

refactor: collapse mcp surface to ledgerr tools#27
elasticdotventures merged 1 commit into
mainfrom
codex-reduce-mcp-surface-ledgerr

elasticdotventures commented Apr 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                        "required": ["date", "amount", "description", "source_ref"],
+                        "required": ["date", "amount", "description", "source_ref"],
+                        "anyOf": [
+                            { "required": ["account_id"] },
+                            { "required": ["account"] }
+                        ],

Conversation

elasticdotventures commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

elasticdotventures commented Apr 16, 2026 •

edited

Loading