feat(prd9): Phase 0 isometric visualization + McpProvider actor/gate + datum logic by promptexecutionerr · Pull Request #63 · PromptExecution/ledgrrr

promptexecutionerr · 2026-05-02T11:35:41Z

Summary

PRD-9 Phase 0: Isometric pipeline visualization types and lint suite for all 20 PRD-6/7 domain types
McpProvider/actor/gate: Extracted ledgerr-mcp-core crate, new actor.rs and gate.rs modules
datum logic: Extended symbolic gate tests (NAND/NOR/ADD/WAIT/TX/RX coverage)
b00t-iface fixes: SARIF module enhancements, clippy/tempdir fixes

PRD-9 Phase 0 details

New files

File	Purpose
`crates/ledger-core/src/iso.rs`	`Vec3`, `IsoProjected`, `iso_project()`, `ZLayer` (6), `SemanticType` (12), `HasVisualization`, `IsoAnimationPath`
`crates/ledger-core/src/iso_objects.rs`	`HasVisualization` impls for all 20 domain types
`crates/ledger-core/tests/iso_lint.rs`	20 lint tests (all pass)
`book/src/iso-pipeline-objects.md`	mdBook chapter with per-type Rhai DSL blocks
`_docs/iso-pipeline.tomllmd`	verbatim/executive/epigram + TOML layer stack + EntanglementRef
`PRD-9.md`	Full specification

ZLayer stack

z=0 Document     #334155  base_z=0.0
z=1 Pipeline     #1d4ed8  base_z=136.0   (9 types)
z=2 Constraint   #7c3aed  base_z=272.0   (5 types)
z=3 Legal        #b91c1c  base_z=408.0   (5 types)
z=4 FormalProof  #0f766e  base_z=544.0   (1 type)
z=5 Attestation  #b45309  base_z=680.0   (reserved: PRD-6-FUTURE)

Projection formula (matches JS rhai-live-core.js)

screen_x = origin_x + (pt.x - pt.z) * scale * 0.866
screen_y = origin_y + (pt.x + pt.z) * scale * 0.5 - pt.y * scale

Animation backends

Phase 0: IsoAnimationPath::to_smil_svg() — SVG SMIL <animateTransform>
Phase 2 stub: IsoAnimationPath::to_manim_script() — Python manim scene

Test plan

cargo test -p ledger-core --test iso_lint — 20/20 pass
cargo check -p ledger-core — clean
cargo check -p ledgerr-mcp — clean

Related issues

Closes prd-9 phase 0: isometric pipeline visualization — HasVisualization + lint suite #62 (PRD-9 Phase 0 isometric visualization)

🤖 Generated with Claude Code

… suite - iso.rs: Vec3/IsoProjected/iso_project(), ZLayer (6 variants), SemanticType (12), VisualizationSpec, HasVisualization trait, IsoEasing, IsoTransform, IsoAnimationPath with to_smil_svg() and to_manim_script(); self-contained (no glam dep) - iso_objects.rs: HasVisualization impls for all 20 PRD-6/7 domain types across z=1 Pipeline, z=2 Constraint, z=3 Legal, z=4 FormalProof layers - tests/iso_lint.rs: 20 lint tests enforcing description/rhai_dsl/z_layer/semantic_type contract per type; all pass - book/src/iso-pipeline-objects.md: mdBook chapter with per-type DSL blocks - _docs/iso-pipeline.tomllmd: verbatim/executive/epigram + TOML layer stack + EntanglementRef + {{ cmd: }} interpolation blocks - SUMMARY.md: wire iso-pipeline-objects chapter into Visualization System section - PRD-9.md: specification document for isometric pipeline visualization Closes #62 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rate - ledgerr-mcp-core: new crate extracting McpProvider trait + StdioMcpProvider, McpProviderRegistry, B00tProvider, JustProvider, Ir0ntologyProvider definitions - actor.rs: MCP actor loop with typed message dispatch - gate.rs: commit gate integration for MCP tool authorization - mcp_adapter.rs: expanded MCP adapter surface - provider.rs: refactored to re-export from ledgerr-mcp-core - datum/logic.rs: additional symbolic gate tests and NAND/NOR/ADD/WAIT/TX/RX coverage - README.md: add Future Ambitions section linking PRD-7, PRD-8, PRD-6-FUTURE Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

elasticdotventures · 2026-05-02T11:45:36Z

@copilot good faith critically evaluate errors, gaps, synergistic capability utilization and idiomatic composition of visual narrative animation readiness

Adds `legacy` feature flag (`cfg-if`-gated) to the old direct-Mutex `mcp_adapter` dispatch functions. The modern actor/gate channel system is the default; the `legacy` flag keeps the pre-PRD-7 dispatch compiled for backward compatibility until the migration is fully validated. Also adds `cfg-if = 1.0` dep, bumps `ledgerr-mcp` and `ledgerr-mcp-core` to 1.8.1, and fixes duplicate `handle_external_tool` definitions from the previous phase.

…tive readiness gaps - mcp_adapter.rs: remove duplicate tool_descriptors/handle_external_tool definitions introduced in PRD-7 commit; add non-legacy tool_names() wrapping BUILTIN_TOOL_NAMES so contract tests pass without the legacy feature - mcp_adapter.rs: gate ToolDescriptor/OnceLock imports under #[cfg(feature = "b00t")] to fix unused-import warnings - gate.rs: remove duplicate #[cfg(feature = \"xero\")] attributes on GateMessage variants - actor.rs: fix Shutdown handling — check for Shutdown before entering catch_unwind boundary so the actor thread terminates correctly instead of continuing to recv - iso.rs: add Display impls for ZLayer and SemanticType for idiomatic use in diagnostics and logging - iso.rs: guard IsoAnimationPath::to_smil_svg against empty transforms (returns \"\") - iso.rs: add xml_attr_escape helper (narrative animation readiness — safe SMIL output) - iso.rs: fix sanitize_class_name empty-input guard; avoid double allocation on first-char capitalise path - iso.rs: add 8 targeted unit tests covering new helpers and edge cases - scripts/mcp_cli_demo.sh: sync with generated_mcp_cli_demo_script() (adds DEMO_ROOT, ONTOLOGY_PATH, spinning-wheels mode, exit 0 guards) — fixes contract_codegen test Agent-Logs-Url: https://github.com/PromptExecution/l3dg3rr/sessions/a3e5a568-6e5c-4ae9-92ac-ffdf7eb13997 Co-authored-by: elasticdotventures <35611074+elasticdotventures@users.noreply.github.com>

- mcp_adapter.rs: remove legacy gates from handle_external_tool (gated on b00t only, not b00t+legacy) so the function is available when b00t is active without needing the legacy feature; server binary already calls it under b00t cfg - mcp_adapter.rs: remove duplicate #[cfg(feature = \"legacy\")] on legacy tool_names - iso.rs: promote xml_attr_escape to pub with corrected doc comment (removes #[allow(dead_code)] - callers can use it for safe SMIL attribute embedding) - iso.rs: fix sanitize_class_name comment to accurately describe the allocation behavior of to_uppercase().collect() Agent-Logs-Url: https://github.com/PromptExecution/l3dg3rr/sessions/a3e5a568-6e5c-4ae9-92ac-ffdf7eb13997 Co-authored-by: elasticdotventures <35611074+elasticdotventures@users.noreply.github.com>

Copilot · 2026-05-02T12:02:21Z

@copilot good faith critically evaluate errors, gaps, synergistic capability utilization and idiomatic composition of visual narrative animation readiness

Good faith critical evaluation — findings and fixes (commits 9770321 → 162affc):

Errors

mcp_adapter.rs — PRD-7 commit left tool_descriptors and handle_external_tool defined twice (compile errors E0428/E0425/E0277). Removed the stale duplicates; added a non-legacy tool_names() wrapper over BUILTIN_TOOL_NAMES so mcp_adapter_contract tests pass without the legacy feature.
gate.rs — every Xero GateMessage variant had #[cfg(feature = "xero")] duplicated (both attributes required, effectively same as single, but noisy). Deduplicated.
mcp_adapter.rs — handle_external_tool was erroneously gated on both b00t AND legacy, meaning the server binary (which calls it under b00t only) would fail to link when legacy was off. Removed the legacy gate; function is now b00t/not(b00t) only.

Gaps

actor.rs — GateMessage::Shutdown was handled with return inside dispatch() but the run() loop kept calling recv() indefinitely. Fixed: Shutdown is now checked before entering catch_unwind, breaking the loop immediately.
iso.rs — IsoAnimationPath::to_smil_svg produced silent empty output when transforms was empty without any signal; now returns "" explicitly so callers can distinguish an empty path from a rendering fault.
sanitize_class_name — no guard for empty input produced an empty class name. Now returns "AScene" as a safe fallback.
scripts/mcp_cli_demo.sh was out of sync with generated_mcp_cli_demo_script() (missing DEMO_ROOT, ONTOLOGY_PATH, spinning-wheels mode, exit 0 guards), causing a contract_codegen test failure. Regenerated.

Idiomatic composition

Added Display impls for ZLayer and SemanticType — enables format!("{layer}") and tracing::debug!(layer=%spec.z_layer) without manual .label()/.known_name() calls.
Corrected a misleading comment in sanitize_class_name that claimed "without an extra allocation" when to_uppercase().collect::<String>() does allocate.

Visual narrative animation readiness

xml_attr_escape promoted from #[allow(dead_code)] fn to pub fn with corrected doc comment — consumers generating SMIL markup with dynamic node labels can now safely escape attribute values before embedding them. The static float/easing inputs inside to_smil_svg are safe without escaping, but custom label-bearing attributes in future animation paths need it.

…nfig

…_datums in CI

…s from CI

…n iso.rs

+            $(
+                {
+                    let mut cap = $crate::logic::FluxCapacitor::new();
+                    let mut ids: Vec<usize> = Vec::new();


+            $(
+                {
+                    let mut cap = $crate::logic::FluxCapacitor::new();
+                    let mut ids: Vec<usize> = Vec::new();


+            $(
+                {
+                    let mut cap = $crate::logic::FluxCapacitor::new();
+                    let mut ids: Vec<usize> = Vec::new();


+            $(
+                {
+                    let mut cap = $crate::logic::FluxCapacitor::new();
+                    let mut ids: Vec<usize> = Vec::new();


+
+        fn call_tool(&self, _name: &str, _arguments: Value) -> ProviderResult<Value> {
+            self.call_count.fetch_add(1, Ordering::SeqCst);
+            self.call_result.as_ref().map_err(|e| e.clone()).and_then(|v| Ok(v.clone()))


+mod tests {
+    use super::*;
+    use crate::{AccountSummary, ListAccountsRequest};
+    use ledger_core::manifest::Manifest;


+
+fn global_raw_service() -> &'static ledgerr_mcp::TurboLedgerService {
+    static PAIR: OnceLock<(&'static ledgerr_mcp::TurboLedgerService, ledgerr_mcp::actor::ServiceHandle)> = OnceLock::new();
+    PAIR.get_or_init(|| build_service()).0


+
+fn global_raw_service() -> &'static ledgerr_mcp::TurboLedgerService {
+    static PAIR: OnceLock<(&'static ledgerr_mcp::TurboLedgerService, ledgerr_mcp::actor::ServiceHandle)> = OnceLock::new();
+    PAIR.get_or_init(|| build_service()).0


Signed-off-by: Brian Horakh <35611074+elasticdotventures@users.noreply.github.com>

Claude Sonnet (coordinator) and others added 2 commits May 2, 2026 21:34

Copilot started work on behalf of elasticdotventures May 2, 2026 11:45 View session

Claude Sonnet (coordinator) and others added 4 commits May 2, 2026 21:48

chore(version): v1.8.1

4a52599

Copilot finished work on behalf of elasticdotventures May 2, 2026 12:02

Copilot AI requested a review from elasticdotventures May 2, 2026 12:02

Claude Sonnet (coordinator) added 9 commits May 2, 2026 22:09

fix(datum): apply clippy autofix for vec_init_then_push and unused mut

5b12fa6

feat(prd9): add VizManifest/VizSpecOwned types and xtask export command

41f251f

feat(prd9): add docs UI scaffolding with isometric canvas and vite co…

27cf983

…nfig

fix(ci): checkout _b00t_ repo for real_datums feature tests

c92f32d

fix(ci): checkout _b00t_ as sibling dir for include_str! path resolution

f960b31

fix(ci): replace --all-features with explicit feature list, skip real…

4917f80

…_datums in CI

fix(ci): remove --all-features, explict feature list, drop real_datum…

3517129

…s from CI

fix(ci): add feat/** to push branch trigger

9bcf48a

fix: RhaiDsl type errors in iso/iso_objects, merge conflict markers i…

6554f0d

…n iso.rs

github-advanced-security AI found potential problems May 2, 2026

View reviewed changes

Merge branch 'main' into feat/prd7-datum-mcp-providers

b9e5696

Signed-off-by: Brian Horakh <35611074+elasticdotventures@users.noreply.github.com>

elasticdotventures merged commit 74082f3 into main May 2, 2026
0 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(prd9): Phase 0 isometric visualization + McpProvider actor/gate + datum logic#63

feat(prd9): Phase 0 isometric visualization + McpProvider actor/gate + datum logic#63
elasticdotventures merged 16 commits into
mainfrom
feat/prd7-datum-mcp-providers

promptexecutionerr commented May 2, 2026

Uh oh!

elasticdotventures commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

promptexecutionerr commented May 2, 2026

Summary

PRD-9 Phase 0 details

New files

ZLayer stack

Projection formula (matches JS rhai-live-core.js)

Animation backends

Test plan

Related issues

Uh oh!

elasticdotventures commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants