Skip to content

feat: checkpoint workspace core updates#73

Merged
elasticdotventures merged 2 commits into
feat/lfmf-ontology-toolsfrom
feat/workspace-core-updates-20260503-134158
May 3, 2026
Merged

feat: checkpoint workspace core updates#73
elasticdotventures merged 2 commits into
feat/lfmf-ontology-toolsfrom
feat/workspace-core-updates-20260503-134158

Conversation

@elasticdotventures
Copy link
Copy Markdown
Member

@elasticdotventures elasticdotventures commented May 3, 2026

Summary

  • checkpoint the current tracked workspace changes across arc-kit-au, b00t-iface, datum, ledger-core, ledgerr-host, ledgerr-mcp, and mdbook-rhai-mermaid
  • preserve the earlier lfmf/ontology tooling PR as the base for this incremental branch

Notes

@elasticdotventures
feat: checkpoint workspace core updates
f82a938 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 3, 2026 13:42
Copilot AI reviewed May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR checkpoints a broad set of in-flight workspace updates across multiple crates (arc-kit-au, b00t-iface, datum, ledger-core, ledgerr-host, ledgerr-mcp, mdbook-rhai-mermaid, plus xtask), primarily consisting of formatting/rustfmt normalization and small structural cleanups while keeping the stacked feat/lfmf-ontology-tools PR as the base.

Changes:

  • Apply widespread formatting and import-order cleanups across workspace crates and tests.
  • Minor refactors to improve readability (multi-line builders/constructors, expanded matches, etc.) without intended behavior changes.
  • Small touch-ups in MCP/host/visualization-related code paths (mostly stylistic).

Reviewed changes

Copilot reviewed 75 out of 76 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xtask/src/viz_manifest.rs Formatting cleanup for visualization manifest export entries/imports.
crates/mdbook-rhai-mermaid/src/parser.rs Import reordering + formatting in parser and tests.
crates/mdbook-rhai-mermaid/src/main.rs Formatting cleanup in book processing + tests.
crates/mdbook-rhai-mermaid/src/emitter.rs Formatting cleanup in mermaid emitter + tests.
crates/ledgerr-xero/src/auth.rs Minor formatting in token exchange flow.
crates/ledgerr-mcp/src/xero_service.rs Formatting cleanup around pending-auth error handling.
crates/ledgerr-mcp/src/providers/definitions.rs Formatting cleanup for env var fallback + tests.
crates/ledgerr-mcp/src/mcp_adapter.rs Formatting cleanup in tool dispatch + provider plumbing.
crates/ledgerr-mcp/src/lib.rs Module ordering + small formatting changes.
crates/ledgerr-mcp/src/gate.rs Import list formatting cleanup.
crates/ledgerr-mcp/src/contract.rs Formatting cleanup for tool specs + args.
crates/ledgerr-mcp/src/bin/ledgerr-mcp-server.rs Formatting cleanup for server dispatch + provider cfg blocks.
crates/ledgerr-mcp/src/actor.rs Formatting cleanup in actor dispatch + tests.
crates/ledgerr-mcp-core/src/provider.rs Formatting cleanup in provider/registry + tests.
crates/ledgerr-host/tests/visualization_e2e.rs Formatting cleanup in visualization E2E tests.
crates/ledgerr-host/tests/phi4_smoke.rs Formatting cleanup in smoke test.
crates/ledgerr-host/src/settings/schema.rs Formatting cleanup for settings resolver signature.
crates/ledgerr-host/src/local_llm_mistral.rs Formatting cleanup in local mistral runtime implementation.
crates/ledgerr-host/src/local_llm.rs Formatting cleanup in GGUF patching helpers.
crates/ledgerr-host/src/lib.rs Re-export ordering/formatting cleanup.
crates/ledgerr-host/src/internal_openai.rs Formatting cleanup in Foundry endpoint discovery + tests.
crates/ledgerr-host/src/evidence.rs Import ordering + formatting cleanup for action strings/tests.
crates/ledgerr-host/src/bin/host-window.rs Formatting cleanup around Windows geometry API fallback.
crates/ledger-core/tests/type_mesh.rs Formatting cleanup in type mesh compile-time tests.
crates/ledger-core/tests/rhai_rules_extended.rs Formatting cleanup in rule tests.
crates/ledger-core/tests/rhai_rules.rs Formatting cleanup in rule tests.
crates/ledger-core/tests/legal_z3_integration.rs Formatting cleanup in legal solver integration tests.
crates/ledger-core/tests/iso_lint.rs Formatting cleanup in ISO spec lint tests.
crates/ledger-core/src/workflow.rs Formatting cleanup in workflow validation/codegen.
crates/ledger-core/src/visualize.rs Formatting cleanup in visualization rendering + tests.
crates/ledger-core/src/verify.rs Formatting cleanup in multi-model verifier implementation + tests.
crates/ledger-core/src/validation.rs Formatting cleanup in meta/verb definitions.
crates/ledger-core/src/slint_viz.rs Formatting cleanup (brace/EOF).
crates/ledger-core/src/render.rs Formatting cleanup for projection helper.
crates/ledger-core/src/pipeline.rs Formatting cleanup for pipeline events/constructors/tests.
crates/ledger-core/src/ontology.rs Formatting cleanup for arc-kit-au re-exports.
crates/ledger-core/src/observability.rs Formatting cleanup for OTLP parsing + builtin rules + tests.
crates/ledger-core/src/lib.rs Module ordering/formatting cleanup.
crates/ledger-core/src/legal.rs Formatting cleanup for Z3 result construction + rule descriptions/tests.
crates/ledger-core/src/ledger_ops.rs Formatting cleanup in ops/dispatcher and related helpers.
crates/ledger-core/src/layout.rs Import ordering + formatting cleanup.
crates/ledger-core/src/iso_objects.rs Formatting cleanup in visualization specs.
crates/ledger-core/src/iso.rs Formatting cleanup in DSL symbol extraction + tests.
crates/ledger-core/src/integration_tests.rs Formatting cleanup in integration test module.
crates/ledger-core/src/graph.rs Formatting cleanup for pipeline edge list.
crates/ledger-core/src/document_shape.rs Formatting cleanup in classifier + tests.
crates/ledger-core/src/constraints.rs Formatting cleanup in constraints + tests.
crates/ledger-core/src/calendar.rs Formatting cleanup in calendar logic + defaults/tests.
crates/datum/src/tomllmd.rs Formatting cleanup in TOMLLMD compiler/parser + tests.
crates/datum/src/protocol.rs Formatting cleanup in protocol lint helpers + tests.
crates/datum/src/logic.rs Formatting cleanup in symbolic logic helpers + tests.
crates/datum/src/lib.rs Formatting cleanup in errors + tests.
crates/datum/src/ast.rs Formatting cleanup in datum parsing/linting + tests.
crates/b00t-iface/src/viz/mod.rs Formatting cleanup in SVG scene rendering + tests.
crates/b00t-iface/src/sarif/mod.rs Formatting cleanup in SARIF structures + lint heuristics + tests.
crates/b00t-iface/src/ralph.rs Formatting cleanup in Ralph loop surface + tests.
crates/b00t-iface/src/metric/mod.rs Formatting cleanup in metric registry + tests.
crates/b00t-iface/src/llm/mod.rs Formatting cleanup in LLM surface capability + logging + tests.
crates/b00t-iface/src/lib.rs Module ordering/formatting cleanup.
crates/b00t-iface/src/handshake/mod.rs Formatting cleanup in handshake surface IO + capability.
crates/b00t-iface/src/gated/mod.rs Module re-export ordering cleanup.
crates/b00t-iface/src/gated/autoresearch.rs Formatting cleanup in autoresearch surface + tests.
crates/b00t-iface/src/exec/harness.rs Formatting cleanup in lifecycle harness orchestration.
crates/b00t-iface/src/core/surface.rs Formatting cleanup in datum watcher base path + capability.
crates/b00t-iface/src/core/promise.rs Formatting cleanup in promise constructors + tests.
crates/b00t-iface/src/core/mod.rs Module ordering + re-export ordering cleanup.
crates/b00t-iface/src/core/machine.rs Formatting cleanup in state machine transitions + tests.
crates/b00t-iface/src/core/governance.rs Formatting cleanup for constraint serialization.
crates/arc-kit-au/src/trace.rs Import ordering cleanup in tests.
crates/arc-kit-au/src/store.rs Import ordering cleanup in tests.
crates/arc-kit-au/src/missing.rs Formatting cleanup in provenance scanner + tests.
crates/arc-kit-au/src/lib.rs Module ordering + re-export ordering cleanup.
crates/arc-kit-au/src/graph.rs Formatting cleanup in graph helpers + tests.
crates/arc-kit-au/src/edge.rs Formatting cleanup in edge types + traversal trait signature.
crates/arc-kit-au/src/builder.rs Formatting cleanup in evidence builder + tests.
crates/arc-kit-au/src/badge.rs Formatting cleanup in badge derivation + tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/mdbook-rhai-mermaid/src/parser.rs Outdated
Comment on lines 1 to 4
use indexmap::IndexMap;
/// Graph-based AST for the rhai pseudo-DSL.
///
/// Two statement forms are supported:
Comment thread crates/ledger-core/src/ledger_ops.rs Outdated
Comment on lines +457 to +461
ws.write_string(0, 0, "tx_id")
.map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
ws.write_string(0, 1, "category")
.map_err(|e| LedgerOpError::Workbook(e.to_string()))?;
ws.write_string(0, 2, "reason")
Comment thread crates/ledger-core/src/verify.rs
Comment on lines 247 to +251
fn test_verification_rejected_low_confidence() {
let proposer_json = r#"{"rule_id":"test","proposed_fix":"x","reasoning":"y","confidence":0.5}"#;
let reviewer_json = r#"{"approved":false,"concerns":["too risky"],"suggestions":[],"confidence":0.6}"#;
let proposer_json =
r#"{"rule_id":"test","proposed_fix":"x","reasoning":"y","confidence":0.5}"#;
let reviewer_json =
r#"{"approved":false,"concerns":["too risky"],"suggestions":[],"confidence":0.6}"#;
@elasticdotventures
Copy link
Copy Markdown
Member Author

elasticdotventures commented May 3, 2026

@copilot apply changes based on the comments in this thread

@elasticdotventures
fix: apply review feedback - doc comment, workbook headers, verify test
5a44339 
- parser.rs: convert outer doc comment to inner module doc (//!) and move before use statements
- ledger_ops.rs: fix write_sheet to use correct headers matching TxProjectionRow fields (tx_id, account_id, date, amount, description, source_ref) and write all field values
- verify.rs: make test_verification_rejected_low_confidence actually invoke verifier.verify() and assert !is_approved()

Agent-Logs-Url: https://github.com/PromptExecution/l3dg3rr/sessions/b1a08908-ae43-4870-9678-d6b9ef09c136

Co-authored-by: elasticdotventures <35611074+elasticdotventures@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

@copilot apply changes based on the comments in this thread

Applied all three review suggestions in commit 5a44339:

  1. parser.rs – Converted the /// comment to an //! inner module doc comment and moved it before the use statements so it properly documents the module.

  2. ledger_ops.rs – Fixed write_sheet to write headers matching all six TxProjectionRow fields (tx_id, account_id, date, amount, description, source_ref) and populate every column per row, eliminating the misleading category/reason headers and empty column 1.

  3. verify.rs – Replaced the placeholder assert!(true) with an actual verifier.verify() call that asserts !outcome.is_approved() when the reviewer's confidence (0.6) falls below the configured threshold (0.80). All 10 verify tests pass.

@elasticdotventures elasticdotventures merged commit d10af84 into feat/lfmf-ontology-tools May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticdotventures