fix(ledger-core): remove conflicting From impl in ingest.rs#93
Merged
Conversation
From<&TransactionInput> for DocumentFields conflicted with Rust's blanket TryFrom via Into. Keep only TryFrom (the fallible parse-aware version). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impl From<&TransactionInput> for DocumentFieldswhich conflicted with Rust's blanketTryFrom<U> for T where U: Into<T>— both impls resolved toTryFrom<&TransactionInput>forDocumentFields, producing E0119TryFromimpl (added in the same commit asFrom) is the correct, fallible version: it parsesamountfrom string toDecimaland returnsDocumentFieldsParseErroron failure — soFromwas redundant and incorrectTest plan
cargo build --workspace— clean, no E0119cargo test -p ledger-core— all tests pass includingtransaction_input_to_document_fields_parses_amountandtransaction_input_to_document_fields_rejects_invalid_amount@copilot please review
🤖 Generated with Claude Code