[codex] validate GitHub Pages docs payload in CI#96
Merged
Conversation
promptexecutionerr
force-pushed
the
codex/validate-pages-docs-ci
branch
from
3ed28e3 to
1381a38
Compare
promptexecutionerr
force-pushed
the
codex/validate-pages-docs-ci
branch
from
1381a38 to
19013ec
Compare
…ility - Add [preprocessor.admonish] to book/book.toml via mdbook-admonish install - Refresh mdbook-admonish.css to v1.20.0 assets - Install mdbook-admonish from padamson/mdbook-admonish@feat/mdbook-0.5-compat (tommilligan/mdbook-admonish#235) in CI and docs workflows — released v1.20.0 was built against mdbook 0.4.x and fails on 0.5's null config fields - Add admonish presence check and install instructions to Justfile docgen recipe - Add smoke-test admonish blocks (note/warning/tip) to book/src/intro.md TODO: pin to a released version once #235 merges upstream Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fig injection mdbook 0.5 reads MDBOOK_* env vars as config key overrides (strips prefix, lowercases, replaces _ with -). MDBOOK_MERMAID_VERSION was being injected as the unknown config key `mermaid-version`, causing `ERROR invalid key` on every docs build. MDBOOK_VERSION had the same risk with `version`. Renaming to TOOL_MDBOOK_VERSION / TOOL_MDBOOK_MERMAID_VERSION avoids the prefix match entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cargo chef prepare failed because kani-proofs was a workspace member but was not copied into the Docker context before the planner stage ran. Adds COPY to both planner (before cargo chef prepare) and builder. Adds wrkflw-ci-build.yml workflow and `just build` recipe to prove the fix locally without Docker: runs cargo chef prepare + ledgerr-mcp build via wrkflw emulation mode, asserting kani-proofs appears in the recipe. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Field was rejected by cocogitto at runtime, blocking cog bump. Removed; merge-commit skipping is handled by ignore_merge_commits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Two workflows were failing GitHub's parse-time validation on every push:
- publish.yml: secrets context is not available during job-level `if:`
evaluation. Moved CRATES_IO_TOKEN/PYPI_API_TOKEN to job-level env vars
and gated each step with `if: ${{ env.TOKEN != '' }}` instead.
- wrkflw-docgen.yml: `runner.temp` is a job-execution context, not
available in workflow-level `env:` blocks. Replaced with `/tmp/sccache`
(always correct in emulation mode where wrkflw runs on the host).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code