Refactor coq-detect-rocq-cli to use with-output-to-string#854
Merged
Matafou merged 1 commit intoProofGeneral:masterfrom Jan 6, 2026
Merged
Refactor coq-detect-rocq-cli to use with-output-to-string#854Matafou merged 1 commit intoProofGeneral:masterfrom
coq-detect-rocq-cli to use with-output-to-string#854Matafou merged 1 commit intoProofGeneral:masterfrom
Conversation
Preserves buffer-local environment e.g. `exec-path`
Contributor
|
Thanks @fdeitylink LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves buffer-local environment e.g.
exec-pathso thatcoq-detect-rocq-cliexecutes the Rocq executable in the same environment as it is executed in other parts of PG. Also a slightly simpler implementation.I use direnv/envrc with Nix and while
coq-autodetect-prognamesuccessfully picks up therocqexecutable,with-temp-bufferdoes not preserve buffer-locals (which myexec-pathis due to the envrc package) and soprocess-fileinside the temporary buffer would report thatrocqcouldn't be found.