Add impersonated user ID to the authentication info#13
Merged
andrew-propelauth merged 1 commit intomainfrom May 4, 2023
Merged
Add impersonated user ID to the authentication info#13andrew-propelauth merged 1 commit intomainfrom
andrew-propelauth merged 1 commit intomainfrom
Conversation
jmcguire
suggested changes
May 4, 2023
| this.lastActiveAt = value | ||
| } else if (key === "legacy_user_id") { | ||
| this.legacyUserId = value | ||
| } else if (key === "impersonator_user") { |
Contributor
There was a problem hiding this comment.
should be impersonator_user_id
Contributor
Author
There was a problem hiding this comment.
This is actually how the backend is sending it, need to keep it for back-compat, but I think impersoantor_user_id is a better thing to expose externally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.