Conversation
Contributor
|
Should we perhaps inform users via warnings about "legacy" projects being used if technically possible? Like |
Member
Author
|
Yes I have something for that but I realized that it's conceptually worth being in a separate pull request. |
First of all, support 'mkdocs.plugins' entrypoints but with a lower priority than ours. At the start of execution, set up a metaimporter such that whenever a plugin imports anything from 'mkdocs.*', the import gets redirected to us. Also keep MkDocsConfig as an alias for the same reason - it was the only renamed class.
Simply support the mkdocs.themes entrypoints but give preference to our entrypoints. Also, populate the mkdocs_version field for themes but with our project name prefix, to distinguish them if the theme renders this value.
Member
Author
|
@Andre601 Oh maybe I misread your message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support running existing mkdocs plugins by redirecting the import
First of all, support 'mkdocs.plugins' entrypoints but with a lower priority than ours.
At the start of execution, set up a metaimporter such that whenever a plugin imports anything from 'mkdocs.*', the import gets redirected to us.
Also keep MkDocsConfig as an alias for the same reason - it was the only renamed class.
Support loading existing mkdocs themes
Simply support the mkdocs.themes entrypoints but give preference to our entrypoints.
Also, populate the mkdocs_version field for themes but with our project name prefix, to distinguish them if the theme renders this value.