Conversation
|
I also think I'd like to make the first release of ProperDocs without this nag message but then soon follow it up with a release that has the nag message. UPDATE: the nag message actually doesn't kick in by itself, so I retract this. Just publish it with the module already available. |
|
This modified version can be tried out by installing Try running through |
|
I'm a bit confused on the actual context of when this would be shown. When a user runs mkdocs while properdocs is installed? When they install a theme/plugin supporting properdocs but use it on mkdocs? It's hard to think of a message without knowing the cases this would actually be shown in. |
Yes, but: all mkdocs plugins work out of the box. |
|
In that case, my idea: |
|
I just want to add the message mkdocs-material has added on plugin init. Rather than a big blurb in the console, why don't we do something similar and create a page on properdocs.org with the full rationale and keep the console message to a few highlighted, important bullet points? I think a wall of text is more easily ignored than a succinct listing of real pain points. |
|
Sure a page is better. I welcome help regarding what to put to the page and what to keep in the console. Note that I'll be suppressing the message from material (needs to be done anyway because it does not know that this is no longer mkdocs) |
a389cd5 to
9604013
Compare
0eb5cf9 to
e5aca10
Compare
Plugin authors can join in on this message by simply calling our special module. (Other than that, there's no way for us to cause it to be imported. So, without any participating plugins nothing happens.) Please add our warning to your MkDocs plugin in the following way: ``` import properdocs.replacement_warning properdocs.replacement_warning.setup() ```
|
Works and looks nice even on Windows 👌 |
|
just don't forget to update the discussion link 😅 |
|
Thanks. Uh yes.. I remembered about that one too late, should've updated already in this PR |
|
Thanks @Andre601 for collaboration on the message. I should've added you somehow to the commit |
|
I personally don't care that much about such things. |
|
Warning fatigue is a reason not to do this. I would like to not have warnings like this pop up in general. ProperDocs is asserting itself in a bad way where instead the project should grow and differentiate itself with improvements. Expand adoption through good ideas, features, and support. Right now the only difference is one project is throwing a warning. A warning end users can't do anything about if it starts showing up in their dependency trees. |
|
Hi. I felt that this was a race against time. mkdocs-material already shows a warning that is not actionable. I am working on bug fixes, and anyone is welcome to do so as well (unlike previously). So there's your differentiation. |
|
i agree with @oprypin |
|
Okay, that's fair; I at least wanted to share my opinion. I appreciate your efforts as I am fully invested in mkdocs 1. I have an offline live editor which supports me automatically refactoring my content (shameless plug mkocs-live-wysiwyg-plugin which is in my GitHub and only supports mkdocs 1). "Users who can't control the warnings" in this case would be those using my editor. I am fully invested in backstage which is currently mkdocs only. I suggest you open a ticket with backstage. Their user base is in the 10s of thousands. Ask them to support properdocs so that I don't have to see warnings :-) |
Add a nagging message when the "mkdocs" executable is detected
Plugin authors can join in on this message by simply calling our special module.
(Other than that, there's no way for us to cause it to be imported. So, without any participating plugins nothing happens.)
This is my main plan regarding how we can expand adoption of this project. Every plugin that joins us will make us stronger.
We should invite plugins to:
Depend on
properdocsANDmkdocs <=1.6.1to limit any future shenanigans of mkdocs. The dependency might be a waste but it's almost guaranteed that something will pull it in anyway.Add our warning to their MkDocs plugin in the following way: