Rewritten documentation#31
Merged
rom1504 merged 3 commits intoProtoDef-io:masterfrom Aug 25, 2020
Saiv46:master
Merged
Conversation
Contributor
Saiv46
commented
Mar 10, 2020
Saiv46
commented
- Added protocol example
- Added protodefc to README (add protodefc to readme #24)
- Moved bool/cstring/void to primitive types
- Added "lvarint" and "int" numeric types
- Formatted schemas
- Make protocol/type description more clear
* Added protocol example * Moved bool/cstring/void to primitive type * Added "lvarint" and "int" numeric types * Formatted schemas
roblabla
reviewed
Mar 12, 2020
Contributor
roblabla
left a comment
roblabla
left a comment
There was a problem hiding this comment.
Hey, I like the new organization. I disagree with adding lvarint though. varint has no notion of endianness in its encoding.
Co-Authored-By: Robin Lambertz <github@roblab.la>
Contributor
Author
rom1504
approved these changes
Aug 25, 2020
Member
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
ok, will remove lvarint after merge
extremeheat
added a commit
to extremeheat/node-protodef-validator
that referenced
this pull request
Jun 10, 2021
ProtoDef-io/ProtoDef#31 moved it from utils.json
rom1504
pushed a commit
to ProtoDef-io/node-protodef-validator
that referenced
this pull request
Jun 10, 2021
ProtoDef-io/ProtoDef#31 moved it from utils.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.