Skip to content

Conversation

@howardwu
Copy link
Member

@howardwu howardwu commented Jun 2, 2020

No description provided.

@howardwu
Copy link
Member Author

howardwu commented Jun 2, 2020

#184

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #184 into master will decrease coverage by 4.42%.
The diff coverage is 33.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   77.91%   73.49%   -4.43%     
==========================================
  Files         281      254      -27     
  Lines       17190    16226     -964     
==========================================
- Hits        13394    11925    -1469     
- Misses       3796     4301     +505     
Impacted Files Coverage Δ
consensus/src/test_data/e2e.rs 28.57% <ø> (ø)
errors/src/parameters/parameters.rs 0.00% <0.00%> (ø)
parameters/src/inner_snark_pk/inner_snark_pk.rs 0.00% <0.00%> (-10.00%) ⬇️
parameters/src/outer_snark_pk/outer_snark_pk.rs 0.00% <0.00%> (-10.00%) ⬇️
posw/src/consensus.rs 79.54% <ø> (ø)
...eters/src/account_commitment/account_commitment.rs 85.71% <75.00%> (-14.29%) ⬇️
...ameters/src/account_signature/account_signature.rs 85.71% <75.00%> (-14.29%) ⬇️
parameters/src/inner_snark_vk/inner_snark_vk.rs 85.71% <75.00%> (-14.29%) ⬇️
...eters/src/ledger_merkle_tree/ledger_merkle_tree.rs 85.71% <75.00%> (-14.29%) ⬇️
...src/local_data_commitment/local_data_commitment.rs 85.71% <75.00%> (-14.29%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdc036...4a72abd. Read the comment docs.

@howardwu howardwu merged commit 45da19a into master Jun 3, 2020
@gakonst gakonst deleted the feature/checksums branch June 4, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants