PDX-0: chore: portable, non-personal paths (PR #201 Copilot review)#204
Merged
Conversation
… docs RCA: Copilot review on PR #201 flagged a hard-coded personal Windows username (mrdai) in an sfSpawn test path and two loop-doc example paths; personal/environment-specific paths are non-portable and embed identifying detail. Fix: Replace mrdai with the generic "username" in the win32 sfSpawn test (still a spaced Windows path, preserving the space-handling assertion) and switch the loop-doc example paths to OS- and user-agnostic ~/git/... form.
Quality Orchestrator🟢 LOW · No test files mapped. ⚡ quality-orchestrator · |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a hard-coded personal username from example paths in tests and documentation, making the repo’s examples portable and non-personal while preserving the intent of the existing Windows space-handling test.
Changes:
- Update the
sfSpawnunit test sample Windows path to use a genericC:\Users\username\...value. - Update loop documentation example testcase paths to use user/OS-agnostic
~/git/...paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/unit/mcp/sfSpawn.test.ts |
Replaces a personal Windows user directory segment in a spaced-path argument test while keeping the space/quoting behavior under test unchanged. |
docs/loops/pdx-501-505.md |
Replaces personal Windows example paths with portable home-directory-based examples for documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the three Copilot review comments on the develop → main PR #201, all flagging a hard-coded personal username (
mrdai) in example paths.test/unit/mcp/sfSpawn.test.ts— the win32 spaced-arg test now usesC:\Users\username\git\Provar Manager\...(generic username; still a Windows path with a space, so the space-handling assertion is unchanged).docs/loops/pdx-501-505.md— the two example testcase paths are now OS- and user-agnostic:~/git/provar-manager-regression/tests/...(instead ofC:\Users\mrdai\git\...).Once merged to
develop, PR #201 (develop → main) picks these up and the Copilot comments are resolved.Test plan
Changes
test/unit/mcp/sfSpawn.test.ts:mrdai→usernamein the spaced--properties-filepath.docs/loops/pdx-501-505.md: twoC:\Users\mrdai\git\...example paths →~/git/....