fix(api): enforce federation JSON-LD context#295
Conversation
|
REVIEW NOTE: this PR intentionally checks ForgeFed JSON-LD semantics, not REST semantics. Please verify against https://forgefed.org/spec/:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.test.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{test,spec}.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (3)
📝 WalkthroughSummary by CodeRabbitПримечания к выпуску
WalkthroughДобавляет JSON‑LD контексты и типы; требует и нормализует ForgeFed+ActivityStreams контексты, протягивает inheritedJsonLdContext через обработку входящих федеративных payload'ов, переключает исходящие федеративные документы и HTTP‑ответы на JSON‑LD, обновляет тесты; параметризует RTK в Dockerfile шаблонах. ИзмененияФедеративная обработка JSON-LD контекста
Диаграмма последовательностиsequenceDiagram
participant RemoteFederation
participant ingestFederationInbox
participant requireFederationJsonLdContext
participant ingestOfferTicket
participant parseTicket
participant MakeFederationActorDocument
participant jsonLdResponse
participant HttpResponse
RemoteFederation->>ingestFederationInbox: POST входящая активность с `@context`
ingestFederationInbox->>requireFederationJsonLdContext: требовать ForgeFed контекст
alt Контекст валиден
requireFederationJsonLdContext-->>ingestFederationInbox: inheritedJsonLdContext
ingestFederationInbox->>ingestOfferTicket: обработать Offer с контекстом
ingestOfferTicket->>parseTicket: парсить Ticket с inherited контекстом
else Контекст невалиден
requireFederationJsonLdContext-->>ingestFederationInbox: ApiBadRequestError
end
RemoteFederation->>MakeFederationActorDocument: GET /federation/actor
MakeFederationActorDocument->>MakeFederationActorDocument: использовать actorJsonLdContext
MakeFederationActorDocument->>jsonLdResponse: сериализовать JSON-LD
jsonLdResponse->>HttpResponse: отправить с federationJsonLdResponseContentType
Оценка сложности кода🎯 3 (Средняя сложность) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/api/src/services/federation.ts`:
- Around line 1495-1503: Remove the unnecessary "as const" assertion used inside
the Effect.as call in fetchOutbox: instead of using `"OrderedCollection" as
const` inline, construct the object with an explicit type annotation of
ActivityPubOrderedCollection (or assign the object to a variable typed as
ActivityPubOrderedCollection) so TypeScript infers the literal
"OrderedCollection" type without using `as`; update the Effect.flatMap branch
that builds the ordered collection (the object with "@context", type, id,
totalItems, orderedItems) to be typed as ActivityPubOrderedCollection and remove
the `as const` assertion.
In `@packages/api/tests/http-config.test.ts`:
- Around line 183-194: Add tests mirroring the existing "serves federation actor
documents as JSON-LD" case for the other federation endpoints
(/federation/outbox, /federation/followers, /federation/following,
/federation/liked). For each endpoint, call
readFederationDocumentRoute("<path>"), parse the response with parseJsonObject,
and assert actor.status === 200, actor.contentType ===
federationJsonLdResponseContentType, and that readField(payload, "@context")
equals the expected JSON-LD context (use actorJsonLdContext or the appropriate
context constant). Reuse the same clearFederationState() setup and test
structure (it.effect + Effect.gen) as in the existing test to ensure
consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7bfde134-0052-4aca-ac36-e33c0bd97790
📒 Files selected for processing (5)
packages/api/src/api/contracts.tspackages/api/src/http.tspackages/api/src/services/federation.tspackages/api/tests/federation.test.tspackages/api/tests/http-config.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: E2E (Login context)
- GitHub Check: E2E (Runtime volumes + SSH)
- GitHub Check: E2E (Clone auto-open SSH)
- GitHub Check: E2E (Browser command)
- GitHub Check: E2E (Clone cache)
- GitHub Check: E2E (OpenCode)
- GitHub Check: Test
- GitHub Check: Lint
- GitHub Check: Final build (windows-latest)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Implement Functional Core, Imperative Shell (FCIS) pattern: CORE layer contains only pure functions with immutable data and mathematical operations; SHELL layer isolates all effects (IO, network, database). Strict dependency direction: SHELL → CORE (never reverse).
Never useany,unknown,eslint-disable,ts-ignore, orastype assertions (except in rigorously justified cases with documentation). Always use exhaustive union type analysis through.exhaustive()pattern matching.
All external dependencies must be wrapped through typed interfaces and injected via Effect-TS Layer pattern. Never call external services directly from CORE functions.
Use monadic composition with Effect-TS for all effects:Effect<Success, Error, Requirements>. Compose effects throughpipe()andEffect.flatMap(). Implement dependency injection via Layer pattern. Handle errors without try/catch blocks.
All functions must be pure in the CORE layer: no side effects (logging, console output, IO operations, mutations). Separate all side effects into the SHELL layer.
Use exhaustive pattern matching with Effect.Match instead of switch statements. Example:Match.value(item).pipe(Match.when(...), Match.exhaustive).
Document all functions with comprehensive TSDoc including:@pure(true/false),@effect(required services),@invariant(mathematical invariants),@precondition,@postcondition,@complexity(time and space),@throwsNever (errors must be typed in Effect).
Use functional comment markers for code clarity: CHANGE (brief description), WHY (mathematical/architectural justification), QUOTE(ТЗ) (requirement citation), REF (RTM or message ID), SOURCE (external source with quote), FORMAT THEOREM (∀x ∈ Domain: P(x) → Q(f(x))), PURITY (CORE|SHELL), EFFECT (Effect type signature), INVARIANT (mathematical invariant), COMPLEXITY (time/space).
Define all external service dependencies as Context.Tag classes with fully typed methods returning Effect types. Example: `class Da...
Files:
packages/api/tests/http-config.test.tspackages/api/src/api/contracts.tspackages/api/src/http.tspackages/api/tests/federation.test.tspackages/api/src/services/federation.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Implement property-based testing using fast-check for mathematical properties and invariants. Example:fc.property(fc.array(messageArbitrary), (messages) => isChronologicallySorted(sortMessagesByTimestamp(messages))).
Mock external dependencies in unit tests using Effect's testing utilities. Run tests without Effect runtime for speed. Example:Effect.provide(MockService), Effect.runPromise.
Files:
packages/api/tests/http-config.test.tspackages/api/tests/federation.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Forbidden constructs in CORE code:any,eslint-disable,ts-ignore,async/await, raw Promise chains (then/catch),Promise.all,try/catchfor logic control,console.*, switch statements (use Match with .exhaustive() instead)
All functions must use Effect-TS for composing effects:Effect<Success, Error, Requirements>. No direct async/await, Promise chains, or try/catch in product logic.
Functional comments must include: CHANGE, WHY, QUOTE(ТЗ) or n/a, REF, SOURCE or n/a, FORMAT THEOREM, PURITY (CORE|SHELL), EFFECT signature for SHELL functions, INVARIANT, and COMPLEXITY.
All data mutations must use immutable patterns (ReadonlyArray, readonly properties, Object.freeze); mutation in SHELL only when absolutely necessary and documented.
Files:
packages/api/tests/http-config.test.tspackages/api/src/api/contracts.tspackages/api/src/http.tspackages/api/tests/federation.test.tspackages/api/src/services/federation.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Property-based tests (fast-check) must verify mathematical invariants; unit tests must use Effect test utilities without async/await.
Files:
packages/api/tests/http-config.test.tspackages/api/tests/federation.test.ts
**/*
⚙️ CodeRabbit configuration file
**/*: Ты строгий ревьюер SPEC DRIVEN DEVELOPMENT.Перед выводами изучи README.md, другие *.md файлы, linked issues,
PR description, PR comments/discussion и релевантную кодовую базу.Сверь изменения с исходным ТЗ/спекой и обсуждением. Флагай любой уход
от спеки, недокументированное изменение поведения, отсутствие тестов
для заявленного поведения и security-риск. Если спека не видна,
попроси автора добавить ее в issue или PR description.Проверь решение с точки зрения формальной верификации: какие инварианты,
предусловия и постусловия можно доказать математически, а где доказуемость
слабая. Оцени решение с точки зрения теории игр: устойчивы ли стимулы,
нет ли выгодного обхода правил, и какое решение было бы сильнее.
Files:
packages/api/tests/http-config.test.tspackages/api/src/api/contracts.tspackages/api/src/http.tspackages/api/tests/federation.test.tspackages/api/src/services/federation.ts
🔇 Additional comments (5)
packages/api/src/api/contracts.ts (1)
493-511: LGTM!Also applies to: 573-573, 589-589, 607-607
packages/api/tests/http-config.test.ts (1)
8-13: LGTM!Also applies to: 51-110
packages/api/src/http.ts (1)
14-15: LGTM!Also applies to: 278-280, 598-604, 869-900
packages/api/tests/federation.test.ts (1)
5-9: LGTM!Also applies to: 84-84, 90-90, 146-146, 162-162, 237-274, 350-356, 364-364, 418-418
packages/api/src/services/federation.ts (1)
37-42: LGTM!Also applies to: 84-85, 107-108, 129-171, 541-603, 629-635, 755-807, 817-818, 877-894, 948-949, 1035-1035, 1189-1270, 1306-1306, 1551-1553, 1703-1703
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/api/src/http.ts`:
- Around line 278-279: Add comprehensive TSDoc to the jsonLdResponse helper:
locate the const jsonLdResponse declaration and prepend a TSDoc block that
documents the parameters and return, and includes the required tags — `@pure`
(false), `@effect` (calls textResponse / uses no external services), `@invariant`
(response content-type equals federationJsonLdResponseContentType),
`@precondition` (data is JSON.stringify-serializable), `@postcondition` (body is
JSON string and content-type is federationJsonLdResponseContentType),
`@complexity` (O(n) time and O(n) space where n is JSON.stringify cost), and
`@throws` Never; also mention that it calls textResponse and references
federationJsonLdResponseContentType so reviewers can trace behavior.
- Around line 598-631: Add comprehensive TSDoc comments for the five exported
handlers (federationActorDocumentResponse, federationOutboxDocumentResponse,
federationFollowersDocumentResponse, federationFollowingDocumentResponse,
federationLikedDocumentResponse) using the federationExchangeStatusResponse
docblock as a template: include `@pure` true/false, `@effect` describing that the
handler reads HttpServerRequest and resolves federation context, `@invariant`
about stable request→document mapping, `@precondition` requiring a non-empty
public origin, `@postcondition` describing the returned ActivityPub document (use
"Person document" for federationActorDocumentResponse and "OrderedCollection"
for outbox/followers/following/liked), `@complexity` with O(1) time/space, and
`@throws` Never; ensure each handler’s description and postcondition are adapted
to its specific document type and place the comment immediately above the
respective exported const.
In `@packages/api/src/services/federation.ts`:
- Around line 128-170: Add comprehensive TSDoc comments for jsonLdContextValues,
hasFederationJsonLdContext, requireFederationJsonLdContext, and
requireNestedFederationJsonLdContext: for each function include a short
description, `@param` tags for each parameter, `@returns` matching the return type,
and the required meta tags `@pure`, `@effect` (describe any Effect error type or
required services), `@invariant` (state the mathematical invariant about the
result), `@precondition`, `@postcondition` (describe behavior for different input
shapes), `@complexity` (time and space complexity), and `@throws` Never (errors are
typed in the Effect return); ensure the Effect-returning functions
(requireFederationJsonLdContext, requireNestedFederationJsonLdContext)
explicitly mention the ApiBadRequestError in the `@effect` description and that
they never throw synchronously.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6fd10df5-ccfe-4e04-9883-f82c06272d0e
📒 Files selected for processing (3)
packages/api/src/http.tspackages/api/src/services/federation.tspackages/api/tests/http-config.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: E2E (Clone cache)
- GitHub Check: E2E (Login context)
- GitHub Check: E2E (Runtime volumes + SSH)
- GitHub Check: E2E (Clone auto-open SSH)
- GitHub Check: E2E (Browser command)
- GitHub Check: E2E (OpenCode)
- GitHub Check: Lint
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Implement Functional Core, Imperative Shell (FCIS) pattern: CORE layer contains only pure functions with immutable data and mathematical operations; SHELL layer isolates all effects (IO, network, database). Strict dependency direction: SHELL → CORE (never reverse).
Never useany,unknown,eslint-disable,ts-ignore, orastype assertions (except in rigorously justified cases with documentation). Always use exhaustive union type analysis through.exhaustive()pattern matching.
All external dependencies must be wrapped through typed interfaces and injected via Effect-TS Layer pattern. Never call external services directly from CORE functions.
Use monadic composition with Effect-TS for all effects:Effect<Success, Error, Requirements>. Compose effects throughpipe()andEffect.flatMap(). Implement dependency injection via Layer pattern. Handle errors without try/catch blocks.
All functions must be pure in the CORE layer: no side effects (logging, console output, IO operations, mutations). Separate all side effects into the SHELL layer.
Use exhaustive pattern matching with Effect.Match instead of switch statements. Example:Match.value(item).pipe(Match.when(...), Match.exhaustive).
Document all functions with comprehensive TSDoc including:@pure(true/false),@effect(required services),@invariant(mathematical invariants),@precondition,@postcondition,@complexity(time and space),@throwsNever (errors must be typed in Effect).
Use functional comment markers for code clarity: CHANGE (brief description), WHY (mathematical/architectural justification), QUOTE(ТЗ) (requirement citation), REF (RTM or message ID), SOURCE (external source with quote), FORMAT THEOREM (∀x ∈ Domain: P(x) → Q(f(x))), PURITY (CORE|SHELL), EFFECT (Effect type signature), INVARIANT (mathematical invariant), COMPLEXITY (time/space).
Define all external service dependencies as Context.Tag classes with fully typed methods returning Effect types. Example: `class Da...
Files:
packages/api/tests/http-config.test.tspackages/api/src/http.tspackages/api/src/services/federation.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Implement property-based testing using fast-check for mathematical properties and invariants. Example:fc.property(fc.array(messageArbitrary), (messages) => isChronologicallySorted(sortMessagesByTimestamp(messages))).
Mock external dependencies in unit tests using Effect's testing utilities. Run tests without Effect runtime for speed. Example:Effect.provide(MockService), Effect.runPromise.
Files:
packages/api/tests/http-config.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Forbidden constructs in CORE code:any,eslint-disable,ts-ignore,async/await, raw Promise chains (then/catch),Promise.all,try/catchfor logic control,console.*, switch statements (use Match with .exhaustive() instead)
All functions must use Effect-TS for composing effects:Effect<Success, Error, Requirements>. No direct async/await, Promise chains, or try/catch in product logic.
Functional comments must include: CHANGE, WHY, QUOTE(ТЗ) or n/a, REF, SOURCE or n/a, FORMAT THEOREM, PURITY (CORE|SHELL), EFFECT signature for SHELL functions, INVARIANT, and COMPLEXITY.
All data mutations must use immutable patterns (ReadonlyArray, readonly properties, Object.freeze); mutation in SHELL only when absolutely necessary and documented.
Files:
packages/api/tests/http-config.test.tspackages/api/src/http.tspackages/api/src/services/federation.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Property-based tests (fast-check) must verify mathematical invariants; unit tests must use Effect test utilities without async/await.
Files:
packages/api/tests/http-config.test.ts
**/*
⚙️ CodeRabbit configuration file
**/*: Ты строгий ревьюер SPEC DRIVEN DEVELOPMENT.Перед выводами изучи README.md, другие *.md файлы, linked issues,
PR description, PR comments/discussion и релевантную кодовую базу.Сверь изменения с исходным ТЗ/спекой и обсуждением. Флагай любой уход
от спеки, недокументированное изменение поведения, отсутствие тестов
для заявленного поведения и security-риск. Если спека не видна,
попроси автора добавить ее в issue или PR description.Проверь решение с точки зрения формальной верификации: какие инварианты,
предусловия и постусловия можно доказать математически, а где доказуемость
слабая. Оцени решение с точки зрения теории игр: устойчивы ли стимулы,
нет ли выгодного обхода правил, и какое решение было бы сильнее.
Files:
packages/api/tests/http-config.test.tspackages/api/src/http.tspackages/api/src/services/federation.ts
🔇 Additional comments (7)
packages/api/src/services/federation.ts (5)
543-543: LGTM!Also applies to: 565-565, 576-576, 591-591, 602-602
628-664: LGTM!Also applies to: 754-796, 798-832, 860-921
1188-1219: LGTM!Also applies to: 1239-1269
1490-1505: LGTM!
382-382: LGTM!Also applies to: 947-947, 1034-1034, 1305-1305, 1551-1551, 1702-1702
packages/api/src/http.ts (1)
896-914: LGTM!packages/api/tests/http-config.test.ts (1)
56-68: LGTM!Also applies to: 95-118, 130-166, 230-244
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/lib/src/core/templates/dockerfile.ts`:
- Around line 97-103: Проблема: скачивание install.sh по постоянному пути
refs/heads/master делает сборку недетерминированной даже при заданном
RTK_VERSION; исправьте RUN-блок в шаблоне (где используется ARG RTK_VERSION и sh
/tmp/rtk-install.sh) чтобы вместо master загружать конкретную версию/тег/коммит,
привязанный к RTK_VERSION (например подставлять RTK_VERSION в URL к
refs/tags/${RTK_VERSION} или к конкретному коммиту), гарантируя, что скачиваемый
install.sh детерминированно соответствует RTK_VERSION; обновите URL в этом же
месте и оставьте поведение удаления /tmp/rtk-install.sh без изменений.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3b4ede5c-d0a5-4964-a498-3147ebd53402
📒 Files selected for processing (3)
packages/app/src/lib/core/templates/dockerfile.tspackages/lib/src/core/templates/dockerfile.tspackages/lib/tests/core/templates.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: E2E (Clone auto-open SSH)
- GitHub Check: E2E (OpenCode)
- GitHub Check: E2E (Runtime volumes + SSH)
- GitHub Check: E2E (Login context)
- GitHub Check: E2E (Clone cache)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Implement Functional Core, Imperative Shell (FCIS) pattern: CORE layer contains only pure functions with immutable data and mathematical operations; SHELL layer isolates all effects (IO, network, database). Strict dependency direction: SHELL → CORE (never reverse).
Never useany,unknown,eslint-disable,ts-ignore, orastype assertions (except in rigorously justified cases with documentation). Always use exhaustive union type analysis through.exhaustive()pattern matching.
All external dependencies must be wrapped through typed interfaces and injected via Effect-TS Layer pattern. Never call external services directly from CORE functions.
Use monadic composition with Effect-TS for all effects:Effect<Success, Error, Requirements>. Compose effects throughpipe()andEffect.flatMap(). Implement dependency injection via Layer pattern. Handle errors without try/catch blocks.
All functions must be pure in the CORE layer: no side effects (logging, console output, IO operations, mutations). Separate all side effects into the SHELL layer.
Use exhaustive pattern matching with Effect.Match instead of switch statements. Example:Match.value(item).pipe(Match.when(...), Match.exhaustive).
Document all functions with comprehensive TSDoc including:@pure(true/false),@effect(required services),@invariant(mathematical invariants),@precondition,@postcondition,@complexity(time and space),@throwsNever (errors must be typed in Effect).
Use functional comment markers for code clarity: CHANGE (brief description), WHY (mathematical/architectural justification), QUOTE(ТЗ) (requirement citation), REF (RTM or message ID), SOURCE (external source with quote), FORMAT THEOREM (∀x ∈ Domain: P(x) → Q(f(x))), PURITY (CORE|SHELL), EFFECT (Effect type signature), INVARIANT (mathematical invariant), COMPLEXITY (time/space).
Define all external service dependencies as Context.Tag classes with fully typed methods returning Effect types. Example: `class Da...
Files:
packages/app/src/lib/core/templates/dockerfile.tspackages/lib/src/core/templates/dockerfile.tspackages/lib/tests/core/templates.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Forbidden constructs in CORE code:any,eslint-disable,ts-ignore,async/await, raw Promise chains (then/catch),Promise.all,try/catchfor logic control,console.*, switch statements (use Match with .exhaustive() instead)
All functions must use Effect-TS for composing effects:Effect<Success, Error, Requirements>. No direct async/await, Promise chains, or try/catch in product logic.
Functional comments must include: CHANGE, WHY, QUOTE(ТЗ) or n/a, REF, SOURCE or n/a, FORMAT THEOREM, PURITY (CORE|SHELL), EFFECT signature for SHELL functions, INVARIANT, and COMPLEXITY.
All data mutations must use immutable patterns (ReadonlyArray, readonly properties, Object.freeze); mutation in SHELL only when absolutely necessary and documented.
Files:
packages/app/src/lib/core/templates/dockerfile.tspackages/lib/src/core/templates/dockerfile.tspackages/lib/tests/core/templates.test.ts
**/*
⚙️ CodeRabbit configuration file
**/*: Ты строгий ревьюер SPEC DRIVEN DEVELOPMENT.Перед выводами изучи README.md, другие *.md файлы, linked issues,
PR description, PR comments/discussion и релевантную кодовую базу.Сверь изменения с исходным ТЗ/спекой и обсуждением. Флагай любой уход
от спеки, недокументированное изменение поведения, отсутствие тестов
для заявленного поведения и security-риск. Если спека не видна,
попроси автора добавить ее в issue или PR description.Проверь решение с точки зрения формальной верификации: какие инварианты,
предусловия и постусловия можно доказать математически, а где доказуемость
слабая. Оцени решение с точки зрения теории игр: устойчивы ли стимулы,
нет ли выгодного обхода правил, и какое решение было бы сильнее.
Files:
packages/app/src/lib/core/templates/dockerfile.tspackages/lib/src/core/templates/dockerfile.tspackages/lib/tests/core/templates.test.ts
**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.test.{ts,tsx}: Implement property-based testing using fast-check for mathematical properties and invariants. Example:fc.property(fc.array(messageArbitrary), (messages) => isChronologicallySorted(sortMessagesByTimestamp(messages))).
Mock external dependencies in unit tests using Effect's testing utilities. Run tests without Effect runtime for speed. Example:Effect.provide(MockService), Effect.runPromise.
Files:
packages/lib/tests/core/templates.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Property-based tests (fast-check) must verify mathematical invariants; unit tests must use Effect test utilities without async/await.
Files:
packages/lib/tests/core/templates.test.ts
🔇 Additional comments (1)
packages/app/src/lib/core/templates/dockerfile.ts (1)
97-103: Дубликат уже поднятой проблемы с непинованным installer URL RTK.Здесь повторяется тот же паттерн, что и в
packages/lib/src/core/templates/dockerfile.ts: при наличииARG RTK_VERSIONна Line 100 используетсяrefs/heads/master, что не фиксирует источник installer по версии.
2 participants
Summary
This PR tightens docker-git federation wire format around ActivityPub/ForgeFed JSON-LD documents. This is not a REST contract change: the federation flow remains ActivityPub/ForgeFed inbox/outbox document exchange.
ForgeFed / JSON-LD REVIEW checklist
Please review this against the ForgeFed spec: https://forgefed.org/spec/
ForgeFed states that it extends ActivityPub and represents forge events as linked data. Its vocabulary section says the ForgeFed JSON-LD context URI is
https://forgefed.org/ns, and implementers must include ActivityPub and ForgeFed contexts or equivalent context mappings. Typical ForgeFed objects use:This PR makes that check explicit and testable:
@contexton inbox payloads, remote actor discovery, and remote outbox documents.Ticketto inherit JSON-LD context from enclosingOffer/Create, which matches JSON-LD semantics.application/ld+json; profile="https://www.w3.org/ns/activitystreams".Acceptcompatible with JSON-LD, ActivityPub JSON, and normal JSON.Validation
bun run --cwd packages/api typecheck bun run --cwd packages/api test bun run --cwd packages/api lint git diff --checkAll passed locally.