Skip to content

fix(shell): allow default local API URL bootstrap#355

Merged
skulidropek merged 9 commits into
mainfrom
codex/default-local-api-url-bootstrap-pr351
May 29, 2026
Merged

fix(shell): allow default local API URL bootstrap#355
skulidropek merged 9 commits into
mainfrom
codex/default-local-api-url-bootstrap-pr351

Conversation

@skulidropek
Copy link
Copy Markdown
Member

Summary

  • Treat default-local DOCKER_GIT_API_URL values as bootstrap hints instead of strict remote controller overrides.
  • Preserve strict failure behavior for custom explicit API URLs.
  • Cover the Windows-like browser startup path in unit tests and browser e2e.

Context

Follow-up for PR #351. This fixes the case where a persisted Windows env var like DOCKER_GIT_API_URL=http://127.0.0.1:3334 prevents local Docker bootstrap.

Verification

  • bun run --cwd packages/app typecheck
  • bun run --cwd packages/app lint
  • bun run --cwd packages/app lint:tests
  • bun run --cwd packages/app lint:effect
  • bun run --cwd packages/app vitest run tests/docker-git/controller.test.ts tests/docker-git/controller-ready.test.ts tests/docker-git/browser-frontend.test.ts
  • DOCKER_GIT_E2E_REUSE_WORKSPACE_INSTALL=1 DOCKER_GIT_E2E_BROWSER_STARTUP_ATTEMPTS=360 bash scripts/e2e/browser-command.sh

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@skulidropek, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d3a8e8a0-261b-427a-a556-df72241edc24

📥 Commits

Reviewing files that changed from the base of the PR and between 6850ded and db0594b.

📒 Files selected for processing (9)
  • packages/api/README.md
  • packages/app/src/docker-git/browser-frontend.ts
  • packages/app/src/docker-git/controller-health.ts
  • packages/app/src/docker-git/controller-reachability.ts
  • packages/app/src/docker-git/controller.ts
  • packages/app/tests/docker-git/browser-frontend.test.ts
  • packages/app/tests/docker-git/controller-ready.test.ts
  • packages/app/tests/docker-git/controller.test.ts
  • scripts/e2e/browser-command.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/default-local-api-url-bootstrap-pr351

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skulidropek skulidropek changed the base branch from codex/controller-host-runtime-skiller to main May 29, 2026 09:02
# Conflicts:
#	packages/app/src/docker-git/controller.ts
#	packages/app/tests/docker-git/controller-ready.test.ts
#	packages/app/tests/docker-git/controller.test.ts
@skulidropek skulidropek force-pushed the codex/default-local-api-url-bootstrap-pr351 branch from 5386e55 to db0594b Compare May 29, 2026 09:03
@skulidropek skulidropek merged commit 1553b16 into main May 29, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants