Conversation
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary --------- Co-authored-by: Maxime Lemonnier <98470688+Malem38@users.noreply.github.com> Co-authored-by: Thonyk <timr.web@free.fr>
…clair#783) ### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
…eclair#789) ### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
About editing the year of the current session
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary --------- Co-authored-by: Thonyk <timr.web@free.fr>
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
* No reason to hide it * Purpose: display the cdr year in Siarnaq : * in order not to hard-code it (changing it every year is bad) * in order to know easily the year Siarnaq thinks it is and catch it early if wrong * Possibly do the same with the status (for the same reasons: pretty annoying to have to use admin rights to be sure of the actual status) Co-authored-by: Maxime Lemonnier <98470688+Malem38@users.noreply.github.com>
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary Co-authored-by: Maxime Lemonnier <98470688+Malem38@users.noreply.github.com>
Co-authored-by: Maxime Lemonnier <98470688+Malem38@users.noreply.github.com>
### Description When deleting all teams, participants must be deleted as well ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary --------- Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
aeecleclair#811) …heduler to access db (backport of #8) * Fix user batch invitation response model * Fix: add missing param in send_emails_from_queue_task * Get db directly using SessionLocal * Store state in global Python variable * Use arq 0.26.3 * Don't keep arq job results after completion to be able to queue new jobs with the same id * Cancel planned notification with the same job_id before queuing a new one * fixup state * Access GLOBAL_STATE in tests init * Remove unexpected state param while disconnecting * Lint * Parametrize test_factory fixture * Lint * Refactor test settings
### Description Please explain the changes you made here. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the documentation, if necessary
Bumps the actions group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update actions checkout to use node 24 by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li> <li>Prepare v5.0.0 release by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2238">actions/checkout#2238</a></li> </ul> <h2>⚠️ Minimum Compatible Runner Version</h2> <p><strong>v2.327.1</strong><br /> <a href="https://github.com/actions/runner/releases/tag/v2.327.1">Release Notes</a></p> <p>Make sure your runner is updated to this version or newer to use this release.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4...v5.0.0">https://github.com/actions/checkout/compare/v4...v5.0.0</a></p> <h2>v4.3.0</h2> <h2>What's Changed</h2> <ul> <li>docs: update README.md by <a href="https://github.com/motss"><code>@motss</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li> <li>Add internal repos for checking out multiple repositories by <a href="https://github.com/mouismail"><code>@mouismail</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li> <li>Documentation update - add recommended permissions to Readme by <a href="https://github.com/benwells"><code>@benwells</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li> <li>Adjust positioning of user email note and permissions heading by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li> <li>Update README.md by <a href="https://github.com/nebuk89"><code>@nebuk89</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li> <li>Update CODEOWNERS for actions by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li> <li>Update package dependencies by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li> <li>Prepare release v4.3.0 by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2237">actions/checkout#2237</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/motss"><code>@motss</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li> <li><a href="https://github.com/mouismail"><code>@mouismail</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li> <li><a href="https://github.com/benwells"><code>@benwells</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li> <li><a href="https://github.com/nebuk89"><code>@nebuk89</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li> <li><a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4...v4.3.0">https://github.com/actions/checkout/compare/v4...v4.3.0</a></p> <h2>v4.2.2</h2> <h2>What's Changed</h2> <ul> <li><code>url-helper.ts</code> now leverages well-known environment variables by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li> <li>Expand unit test coverage for <code>isGhes</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.1...v4.2.2">https://github.com/actions/checkout/compare/v4.2.1...v4.2.2</a></p> <h2>v4.2.1</h2> <h2>What's Changed</h2> <ul> <li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Jcambass"><code>@Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1919">actions/checkout#1919</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.0...v4.2.1">https://github.com/actions/checkout/compare/v4.2.0...v4.2.1</a></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>V5.0.0</h2> <ul> <li>Update actions checkout to use node 24 by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li> </ul> <h2>V4.3.0</h2> <ul> <li>docs: update README.md by <a href="https://github.com/motss"><code>@motss</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li> <li>Add internal repos for checking out multiple repositories by <a href="https://github.com/mouismail"><code>@mouismail</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li> <li>Documentation update - add recommended permissions to Readme by <a href="https://github.com/benwells"><code>@benwells</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li> <li>Adjust positioning of user email note and permissions heading by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li> <li>Update README.md by <a href="https://github.com/nebuk89"><code>@nebuk89</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li> <li>Update CODEOWNERS for actions by <a href="https://github.com/TingluoHuang"><code>@TingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li> <li>Update package dependencies by <a href="https://github.com/salmanmkc"><code>@salmanmkc</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li> </ul> <h2>v4.2.2</h2> <ul> <li><code>url-helper.ts</code> now leverages well-known environment variables by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li> <li>Expand unit test coverage for <code>isGhes</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li> </ul> <h2>v4.2.1</h2> <ul> <li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li> </ul> <h2>v4.2.0</h2> <ul> <li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li> <li>Dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li> </ul> <h2>v4.1.7</h2> <ul> <li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li> <li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li> <li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li> </ul> <h2>v4.1.6</h2> <ul> <li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li> </ul> <h2>v4.1.5</h2> <ul> <li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li> <li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li> <li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li> <li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li> <li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li> </ul> <h2>v4.1.4</h2> <ul> <li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li> <li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li> <li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li> <li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li> </ul> <h2>v4.1.3</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/08c6903cd8c0fde910a37f88322edcfb5dd907a8"><code>08c6903</code></a> Prepare v5.0.0 release (<a href="https://redirect.github.com/actions/checkout/issues/2238">#2238</a>)</li> <li><a href="https://github.com/actions/checkout/commit/9f265659d3bb64ab1440b03b12f4d47a24320917"><code>9f26565</code></a> Update actions checkout to use node 24 (<a href="https://redirect.github.com/actions/checkout/issues/2226">#2226</a>)</li> <li>See full diff in <a href="https://github.com/actions/checkout/compare/v4...v5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Description Close aeecleclair#577
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
# Description ## Summary Added more export options to Challenger ## Changes Made Added - captains exporter - sport participants exporter - school users exporter - school quotas exporter - sport quotas exporter <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [x] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [x] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
# Description ## Summary This PR fixes how slow the get_current_user_loaners endpoint is (the one we wait for before the admin button shows up) and improves the tests and factory for the loan module. The loan factory didn't use real groups to create loaners from, so they couldn't be used in the same way as a loan created through the app, which defeats the purpose. The factory and tests now behave the same way as the endpoints do, by creating LoanContent in db. The tests now actually check some of the output rather than only the response status code. Some relationship loading models have been changed to not load unnecessary data, which necessitated a really slow call to unique(). <!--Don't touch these two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!-->  That's why <!--#### Sources at the end--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Display the amount in euros (float), rounded with 2 digits after comma, then "€". <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary There were 18 mypy errors lying around in the main branch, and there are none, now. ## Issues/PR dependencies None ### Issues to be resolved None ### Required PRs None ## Changes Made - [x] Remove the mypy errors ## Additional Notes <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [x] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
## Description ### Summary <!--Brief description of what this PR does.--> Now we can enjoy using workers locally even without Redis: it was only useful to set a lock on initialization. ## Changes Made <!--Please describe the changes made in this pull request--> - made a distinction between the number of workers, and having a Redis instance or not - the fallback Redis-less lock is just allowing the first worker to run the 5 init functions: the iterator of workers always output the element in the same order (tested locally in `dev` (necessarily 1 worker), and in `run` with 1 (no `--worker` flag), 2, 3, 4, 6, 8 and 12 workers) ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other ## Testing - [ ] Added/modified tests that pass the CI - [ ] Tested in a pre-prod - [x] Tested this locally ## Documentation - [ ] Updated docs accordingly (docs.myecl.fr) : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] Code includes docstrings - [x] Inline comment - [ ] No documentation needed ## Checklist - [ ] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [ ] Any dependent changes have been merged and published (_Indicate the linked PR for the dependent changes_) ## Additional Notes Add any other context, screenshots, or information about the pull request here. --------- Co-authored-by: Lühmos <guillaume.foucher.pele@gmail.com>
## Description ### Summary The BDE secretary asked that Respo TE be a role of the bureau for the BDE <!--Sources/references at the end--> ### Issues to be resolved <!-- If applicable--> <!--Use keywords "closes", "fixes", "resolves", or others at https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests --> <!--Fixes #--> <!--Fixes aeecleclair/CalypSSO#--> ### Required PRs <!-- If applicable--> <!--Use keywords "depends on" or "blocked by", see https://github.com/gregsdennis/dependencies-action --> <!--Depends on #--> <!--Depends on aeecleclair/CalypSSO#--> ### Changes Made <!--Please describe the changes made in this pull request--> <!--Tell the big steps, use a checklist to show progress. You can explain here how the code works.--> - [x] ... - [ ] ... ### Additional Notes <!--Anything relevant that does not quite fit in the summary--> <details> <summary> ## Classification </summary> ### Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ### Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: <!--not module-oriented--> ### Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI - [ ] 3. Tested in a pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ### Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details> --------- Co-authored-by: Timothée Robert <timr.web@free.fr>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> See my memo at aeecleclair#925, the goal of this PR is to resolve the heap of things in this issue. ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> Fixes aeecleclair#925 ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] CoreUsersFactory - [x] Valid ASCII emails - [x] Catch collisions - [x] Don't crash if exactly 1 demo user - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [x] Other: see aeecleclair#925 <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details> --------- Co-authored-by: Lühmos <guillaume.foucher.pele@gmail.com> Co-authored-by: Maillard Antoine <tan.maillard@gmail.com>
# Description ## Summary The memberships factory was not run because memberships had already been declared by other factories. <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [x] Other: Small factory fix ## Testing - [x] 1. Tested this locally - [x] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> MINIMAL_TITAN_VERSION_CODE was a string instead of an integer as required by /information endpoint. <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Replaced str cast by int cast in Settings ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary Some inconsistencies I've noticed here and there, while working on the OIDC integration for upcoming the Minecraft proxy. This PR simply gathers them and attempts to fix them. <!--#### Sources at the end--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Minecraft: send the user ID in the `sub` claim, not the `id` claim - `id` is a non-standard claim. [^1] - per the specs: *The sub (subject) Claim MUST always be returned in the UserInfo Response.* [^2] - [x] Minecraft: no empty “nickname”: the behavior I chose is the firstname if the user doesn't have a nickname - per the specs: *If a Claim is not returned, that Claim Name SHOULD be omitted from the JSON object representing the Claims; it SHOULD NOT be present with a null or empty string value.* [^2][^3] - what we send to the relying party is, in the general case, neither the nickname nor the firstname, so we can't use these claims. It is what we want the user to be referred to as, it's not official, it can have weird characters. The standard claim `preferred_username` is exactly what we want: *Shorthand name by which the End-User wishes to be referred to at the RP, such as janedoe or j.doe. This value MAY be any valid JSON string including special characters such as @, /, or whitespace. The RP MUST NOT rely upon this value being unique, as discussed in [Section 5.7](https://openid.net/specs/openid-connect-core-1_0.html#ClaimStability).* [^1] - [x] Always values of the `ScopeType` enum (there was 1 `"email"`) - [x] Use the openid and profile scopes interchangeably - [x] Some additions to the metadata we publicly expose [^4] - Registration endpoint pointing at CalypSSO - A couple more standard claims [^1] that we actually support - URI to the privacy policy & ToS with CalypSSO's UI - Prepared the comment for service documentation to docs.myecl.fr [^1]: https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims [^2]: https://openid.net/specs/openid-connect-core-1_0.html#UserInfoResponse [^3]: https://openid.net/specs/openid-connect-core-1_0.html#JSONSerialization [^4]: https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [x] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [x] `#` Inline comments - [ ] No documentation needed </details>
# Description ## Summary Challenger data exporters had a faulty offset <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] removed magic numbers ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> Add of a new type of manager with less rights on the structure (administrator) to include vice treasurer or president for example <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Add of a new model - [x] Modification of permissions ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [x] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details> --------- Co-authored-by: Thonyk <timr.web@free.fr>
# Description ## Summary <!--BRIEF description: DON'T EXPLAIN the code: JUSTIFY what this PR is for!--> Allows volunteer validation and auto validate free products Fix participation cancelling <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
# Description ## Summary <!--BRIEF description: DON'T EXPLAIN the code: JUSTIFY what this PR is for!--> Correctly fuse payment users during user fusion <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then aeecleclair#123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [ ] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [x] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [ ] 1. Tested this locally - [x] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [x] `"` Docstrings - [x] `#` Inline comments - [ ] No documentation needed </details>
Co-authored-by: Timothée Robert <114694873+Rotheem@users.noreply.github.com>
armanddidierjean
force-pushed
the
dev-merged
branch
2 times, most recently
from
250cc00 to
8a23b07
Compare
armanddidierjean
force-pushed
the
dev-merged
branch
from
8a23b07 to
dc46940
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Rotheem
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist