Lint Cleanup
The codebase has 124 pre-existing lint issues detected by golangci-lint v2. Currently CI uses `only-new-issues: true` to avoid blocking PRs.
Breakdown
- errcheck: 50 — unchecked error returns
- staticcheck: 50 — various static analysis findings
- unused: 12 — unused functions, variables, struct fields
- ineffassign: 10 — ineffectual assignments
- govet: 2 — copies lock value
Approach
Fix incrementally by package, one PR per package:
- `go/inst/` — largest package, most issues
- `go/logic/` — recovery logic
- `go/http/` — API handlers
- `go/kv/` — consul/zk stores
- Others
Once all fixed, remove `only-new-issues: true` from CI so lint enforces on all code.
Lint Cleanup
The codebase has 124 pre-existing lint issues detected by golangci-lint v2. Currently CI uses `only-new-issues: true` to avoid blocking PRs.
Breakdown
Approach
Fix incrementally by package, one PR per package:
Once all fixed, remove `only-new-issues: true` from CI so lint enforces on all code.