Migrate Go module path from openark to proxysql#25
Conversation
Update module path from github.com/openark/orchestrator to github.com/proxysql/orchestrator, and github.com/openark/golib to github.com/proxysql/golib, across go.mod, go/golib/go.mod, and all Go source files. Re-vendored dependencies. Closes #17
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (108)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request executes a significant refactoring by migrating the project's Go module paths from the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the Go module path from github.com/openark/orchestrator to github.com/proxysql/orchestrator, and github.com/openark/golib to github.com/proxysql/golib. This is a large but straightforward find-and-replace operation across many files, including updating import paths and URLs in comments. The changes appear to be correct and complete according to the PR's goal. I have not found any issues.
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s Go module and import paths from the legacy github.com/openark/... namespace to github.com/proxysql/..., updating both the main module and the local go/golib dependency, and regenerating vendored dependencies to match.
Changes:
- Update root
go.modmodule path togithub.com/proxysql/orchestratorand rewrite imports across Go packages undergo/. - Migrate golib imports to
github.com/proxysql/golib, updatego/golib/go.mod, and adjust vendoring metadata accordingly. - Re-vendor dependencies, adding the
vendor/github.com/proxysql/golib/...tree and updatingvendor/modules.txt.
Reviewed changes
Copilot reviewed 99 out of 108 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Switch main module path and update golib require/replace for migration |
| go/agent/agent.go | Update internal import path to proxysql module |
| go/agent/agent_dao.go | Update orchestrator/golib imports to proxysql paths |
| go/agent/instance_topology_agent.go | Update golib/orchestrator imports to proxysql paths |
| go/app/cli.go | Update orchestrator/golib imports to proxysql paths |
| go/app/cli_test.go | Update golib/orchestrator imports to proxysql paths |
| go/app/command_help.go | Update repository URL in header comment |
| go/app/http.go | Update orchestrator/golib imports to proxysql paths |
| go/attributes/attributes_dao.go | Update golib/orchestrator imports to proxysql paths |
| go/cmd/orchestrator/main.go | Update orchestrator/golib imports to proxysql paths |
| go/collection/collection.go | Update commented golib import + config import path |
| go/config/config.go | Update golib import path |
| go/config/config_test.go | Update golib imports to proxysql paths |
| go/db/db.go | Update golib/config imports to proxysql paths |
| go/db/tls.go | Update golib/config/ssl imports to proxysql paths |
| go/discovery/aggregated.go | Update collection import path |
| go/discovery/metric.go | Update inst import path |
| go/discovery/metric_json.go | Update collection import path |
| go/discovery/queue.go | Update golib/config/inst imports to proxysql paths |
| go/discovery/queue_aggregated_stats.go | Update golib import path |
| go/golib/go.mod | Set golib module path under proxysql namespace |
| go/golib/sqlutils/sqlutils.go | Update golib/log import path |
| go/http/agents_api.go | Update orchestrator imports to proxysql paths |
| go/http/api.go | Update golib/util + orchestrator imports to proxysql paths |
| go/http/api_test.go | Update golib/config imports to proxysql paths |
| go/http/httpbase.go | Update orchestrator imports to proxysql paths |
| go/http/raft_reverse_proxy.go | Update golib + raft imports to proxysql paths |
| go/http/web.go | Update config/inst imports to proxysql paths |
| go/inst/analysis.go | Update config import path |
| go/inst/analysis_dao.go | Update golib + orchestrator imports to proxysql paths |
| go/inst/analysis_test.go | Update golib/config imports to proxysql paths |
| go/inst/audit_dao.go | Update golib + config/db imports to proxysql paths |
| go/inst/binlog_test.go | Update golib/config imports to proxysql paths |
| go/inst/candidate_database_instance.go | Update db import path |
| go/inst/candidate_database_instance_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/cluster.go | Update config/kv imports to proxysql paths |
| go/inst/cluster_alias_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/cluster_domain_dao.go | Update golib + config/db imports |
| go/inst/cluster_test.go | Update golib/config imports to proxysql paths |
| go/inst/dead_instance_filter.go | Update golib/config imports to proxysql paths |
| go/inst/downtime.go | Update config import path |
| go/inst/downtime_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/instance.go | Update golib + config imports to proxysql paths |
| go/inst/instance_binlog.go | Update golib + config imports to proxysql paths |
| go/inst/instance_binlog_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/instance_dao.go | Update golib + orchestrator imports to proxysql paths |
| go/inst/instance_dao_test.go | Update golib/tests import to proxysql path |
| go/inst/instance_key.go | Update config import path |
| go/inst/instance_key_map_test.go | Update golib/config imports to proxysql paths |
| go/inst/instance_key_test.go | Update golib/config imports to proxysql paths |
| go/inst/instance_test.go | Update golib/config imports to proxysql paths |
| go/inst/instance_topology.go | Update golib + config/os imports to proxysql paths |
| go/inst/instance_topology_dao.go | Update golib/sqlutils + config/db/util imports |
| go/inst/instance_topology_dao_test.go | Update golib/config imports to proxysql paths |
| go/inst/instance_topology_test.go | Update golib/config imports to proxysql paths |
| go/inst/maintenance.go | Update config import path |
| go/inst/maintenance_dao.go | Update golib/sqlutils + config/db/process/util imports |
| go/inst/master_equivalence_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/oracle_gtid_set_test.go | Update golib/tests import to proxysql path |
| go/inst/pool.go | Update golib/config imports to proxysql paths |
| go/inst/pool_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/postponed_functions.go | Update golib import path |
| go/inst/resolve.go | Update golib/config imports to proxysql paths |
| go/inst/resolve_dao.go | Update golib/sqlutils + config/db imports |
| go/inst/tag_dao.go | Update golib/sqlutils + db imports |
| go/inst/tag_test.go | Update golib/tests import to proxysql path |
| go/inst/write_buffer.go | Update collection/config imports to proxysql paths |
| go/kv/consul.go | Update config + golib imports to proxysql paths |
| go/kv/consul_test.go | Update issue link in comment to proxysql repo |
| go/kv/consul_txn.go | Update config + golib imports to proxysql paths |
| go/kv/consul_txn_test.go | Update config import path |
| go/kv/internal.go | Update golib/sqlutils + db imports |
| go/kv/kv.go | Update config import path |
| go/kv/zk.go | Update config import path |
| go/logic/command_applier.go | Update orchestrator + golib imports |
| go/logic/disable_recovery.go | Update golib/sqlutils + db imports |
| go/logic/orchestrator.go | Update orchestrator + golib imports |
| go/logic/snapshot_data.go | Update orchestrator + golib imports |
| go/logic/topology_recovery.go | Update orchestrator + golib imports + issue link comment |
| go/logic/topology_recovery_dao.go | Update orchestrator + golib imports |
| go/metrics/graphite.go | Update orchestrator + golib imports |
| go/metrics/metrics.go | Update config import path |
| go/metrics/query/aggregated.go | Update collection import path |
| go/os/process.go | Update golib/config imports |
| go/os/unixcheck.go | Update golib import path |
| go/process/access_token_dao.go | Update golib/sqlutils + orchestrator imports |
| go/process/election_dao.go | Update golib/sqlutils + orchestrator imports |
| go/process/health.go | Update orchestrator + golib imports |
| go/process/health_dao.go | Update orchestrator + golib imports |
| go/process/host.go | Update golib import path |
| go/raft/file_snapshot.go | Update golib import path |
| go/raft/fsm.go | Update golib import path |
| go/raft/http_client.go | Update orchestrator + golib imports |
| go/raft/raft.go | Update orchestrator + golib imports |
| go/raft/rel_store.go | Update golib/sqlutils imports |
| go/raft/store.go | Update golib import path |
| go/ssl/ssl.go | Update golib/config imports |
| go/ssl/ssl_test.go | Update config/ssl imports |
| go/util/token_test.go | Update golib/tests import to proxysql path |
| vendor/modules.txt | Update vendoring metadata from openark/golib to proxysql/golib |
| vendor/github.com/mattn/go-sqlite3/sqlite3_opt_percentile.go | Add vendored build-tag file (from re-vendor) |
| vendor/github.com/proxysql/golib/log/log.go | Add vendored proxysql/golib logging package |
| vendor/github.com/proxysql/golib/math/math.go | Add vendored proxysql/golib math helpers |
| vendor/github.com/proxysql/golib/sqlutils/dialect.go | Add vendored proxysql/golib sqlutils dialect helpers |
| vendor/github.com/proxysql/golib/sqlutils/sqlite_dialect.go | Add vendored proxysql/golib sqlite dialect translations |
| vendor/github.com/proxysql/golib/sqlutils/sqlutils.go | Update vendored sqlutils import path to proxysql/golib/log |
| vendor/github.com/proxysql/golib/tests/spec.go | Add vendored test helper (contains minor comment typos) |
| vendor/github.com/proxysql/golib/util/text.go | Add vendored proxysql/golib util helpers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,3 @@ | |||
| module golib | |||
| module github.com/proxysql/golib | |||
There was a problem hiding this comment.
go/golib is a subdirectory module within this repo, but its module path is set to github.com/proxysql/golib (implying a separate repository). If the intent is to keep this as an in-repo module, consider changing the module path to github.com/proxysql/orchestrator/go/golib to match the directory layout and avoid requiring an external proxysql/golib module for downstream builds.
| module github.com/proxysql/golib | |
| module github.com/proxysql/orchestrator/go/golib |
| github.com/patrickmn/go-cache v2.1.0+incompatible | ||
| github.com/proxysql/golib v0.0.0-20210531070646-355f37940af8 | ||
| github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9 |
There was a problem hiding this comment.
github.com/proxysql/golib is required here, but the codebase also vendors and replaces it from ./go/golib. If go/golib is intended to remain an in-repo submodule (no separate proxysql/golib repo), consider switching imports/require to github.com/proxysql/orchestrator/go/golib so downstream users of github.com/proxysql/orchestrator (as a dependency) don’t need an external github.com/proxysql/golib module.
| replace ( | ||
| github.com/hashicorp/raft => github.com/openark/raft v0.0.0-20170918052300-fba9f909f7fe | ||
| github.com/openark/golib => ./go/golib | ||
| github.com/proxysql/golib => ./go/golib |
There was a problem hiding this comment.
This replace github.com/proxysql/golib => ./go/golib only applies when this repo is the main module; it won’t be honored when github.com/proxysql/orchestrator is used as a library dependency. If library consumption matters, either (a) make golib’s module path a subpath of this repo (e.g. github.com/proxysql/orchestrator/go/golib) and update imports accordingly, or (b) ensure github.com/proxysql/golib is a real standalone module published at the required version(s).
| github.com/proxysql/golib => ./go/golib |
Summary
github.com/openark/orchestratortogithub.com/proxysql/orchestratorgithub.com/openark/golibtogithub.com/proxysql/golibgo/golib/go.modmodule declaration togithub.com/proxysql/golibgo/go mod tidy && go mod vendorCloses #17
Test plan
go build -o /dev/null go/cmd/orchestrator/main.gosucceedsgo test -vet=off ./go/...all tests pass (vet failures are pre-existing, unrelated to this change)github.com/openark/orchestratororgithub.com/openark/golibreferences remain in Go source files (excluding vendor)