[BUG] Problem with requests when repeatedly quickly

[CyberMew]

Proxyman version? (Ex. Proxyman 1.4.3)

2.33.0

macOS Version? (Ex. mac 10.14)

11.6

Steps to reproduce

Repeat call of a request by spamming cmd+return quickly, say 5 times. The ID will not be in correct order and request should go through.

Expected behavior

ID should be sequential, and http status code of those request should not be 999

Screenshots (optional)

This seems like some race condition issue to me, but I am happy to be wrong if this isn't a bug.

[NghiaTranUIT]

Confirmed that it's a bug from Proxyman @CyberMew. Thanks for creating a bug 🙌

[VinceFilary]

There seems to be some kind of request ID counter race condition.

Multiple requests (not originating from Proxyman) can be assigned the same ID when made quick enough.
Both requests will go through and have separate entries in the log table and respond & complete properly.
(Only seeing the Error / 999 status issue when using CMD + Return)

This issue also impacts scripting and sharedState since they have the same ID, there is no way to differentiate between these requests/responses.

[NghiaTranUIT]

Thanks @VinceFilary I'm going to investigate and fix it now 👍

[NghiaTranUIT]

@VinceFilary @CyberMew please try this build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_3.1.0_Fix_repeated_requests.dmg

I've fixed the issue where:

• Repeated requests causes duplicated request ID
• Small race condition issue on the ID number

[VinceFilary]

Just tested out build you provided @NghiaTranUIT .

Issue is resolved when repeatings requests quickly using CMD + Return.
Issue is also resolved when sending multiple requests quickly not originating from Proxyman.

However, when I Enable Scripting Tool and enable for an endpoint it starts assigning the same ID to separate requests again.

Additional debug info:

If I enable Enable Scripting Tool, and disable the matching rule for the endpoint it doesn't happen.
It happens even if I use the default scripting template, so it's not an issue with my custom script.

[NghiaTranUIT]

Can you share the screenshot of the same ID in separated requests? (You can censor your sensitive URL)

From what I understand, the Scripting doesn't issue any new request ID, so I'm not sure how it looks like 🤔