Fix CFBundleVersion in framework bundle#27
Merged
NghiaTranUIT merged 2 commits intoProxymanApp:mainfrom Nov 3, 2020
Merged
Conversation
And also VERSIONING_SYSTEM = apple-generic to ease use of agvtool in the future
Member
|
Thanks for the first PR @florianbuerger 🙌 I tested and it works fine 👍 I will add some test and setup CI/CD to make it's easier 😄 |
NghiaTranUIT
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Thank you so so much for Atlantis! I've been a big fan of Proxyman and I have been using since the beginning. I always wished for an easier way to capture traffic from test devices. I also often forgot to revert the proxy settings on the device and then wonder why it isn't connected anymore 🙄
Anyway, I tried to publish an app to TestFlight but the validation doesn't pass. The framework was integrated by Carthage.
The framework bundle needs to include a value for
CFBundleVersion. It was set toCURRENT_PROJECT_VERSIONbut that variable wasn't set in the project file. I set it to1for now, just to pass the App Store Connect validation.I also bumped the
CFBundleShortVersionto 1.1.0 even though I don't think it will be used anywhere.