Skip to content

Fix CFBundleVersion in framework bundle#27

Merged
NghiaTranUIT merged 2 commits intoProxymanApp:mainfrom
florianbuerger:main
Nov 3, 2020
Merged

Fix CFBundleVersion in framework bundle#27
NghiaTranUIT merged 2 commits intoProxymanApp:mainfrom
florianbuerger:main

Conversation

@florianbuerger
Copy link
Copy Markdown
Contributor

Hey,

Thank you so so much for Atlantis! I've been a big fan of Proxyman and I have been using since the beginning. I always wished for an easier way to capture traffic from test devices. I also often forgot to revert the proxy settings on the device and then wonder why it isn't connected anymore 🙄


Anyway, I tried to publish an app to TestFlight but the validation doesn't pass. The framework was integrated by Carthage.

ERROR ITMS-90056: "This bundle Payload/Flighty Int.app/Frameworks/Atlantis.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion"

The framework bundle needs to include a value for CFBundleVersion. It was set to CURRENT_PROJECT_VERSION but that variable wasn't set in the project file. I set it to 1 for now, just to pass the App Store Connect validation.

I also bumped the CFBundleShortVersion to 1.1.0 even though I don't think it will be used anywhere.

And also VERSIONING_SYSTEM = apple-generic to ease use of agvtool in the future
@NghiaTranUIT
Copy link
Copy Markdown
Member

Thanks for the first PR @florianbuerger 🙌

I tested and it works fine 👍

I will add some test and setup CI/CD to make it's easier 😄

@NghiaTranUIT NghiaTranUIT merged commit 3286273 into ProxymanApp:main Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants