Skip to content

Conversation

@johannaSommer
Copy link
Member

Description

This PR uses an pruna engine function we already have (determines the model class from the config json file) to simplify fixture construction for our tests with diffusers pipelines.

Related Issue

None.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the tests locally - they fail until a quick extension for the diffusers loading function is merged, hence a draft for now.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

@johannaSommer johannaSommer force-pushed the tests/simplify-fixtures branch from a18716a to 67f8054 Compare July 7, 2025 08:05
@johannaSommer johannaSommer marked this pull request as ready for review July 7, 2025 08:06
Copy link
Collaborator

@nifleisch nifleisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, LGTM! 🙌

@johannaSommer johannaSommer merged commit 67e9032 into main Jul 7, 2025
6 checks passed
@johannaSommer johannaSommer deleted the tests/simplify-fixtures branch July 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants