-
Notifications
You must be signed in to change notification settings - Fork 75
test: add pytest and code coverage configuration in pyproject.toml
#230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add pytest and code coverage configuration in pyproject.toml
#230
Conversation
johannaSommer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already good to me! I have just one quick question on the markers :)
pyproject.toml
Outdated
| "src/pruna/tests", | ||
| ] | ||
|
|
||
| markers = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case could we remove the markers from the conftest.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the markers need to be present in conftest.py that provide reusable setup/teardown logic for tests. We have defined the markers here to maintain a reference of all the markers available. We could remove them if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParagEkbote, should we remove markers from here? It would be difficult to maintain them in two different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. @davidberenstein1957
I've removed them. Could you please review?
|
@ParagEkbote thanks again for the lovely PR! They are really welcome :) |
Description
As described in the issue, I have added the pytest configuration as well the code coverage configuration to get better output and verbosity when the tests are executed.
Could you please review?
cc: @johannaSommer
Related Issue
Fixes #228
Type of Change
How Has This Been Tested?
Checklist