Skip to content

Conversation

@ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Jul 5, 2025

Description

As described in the issue, I have added the pytest configuration as well the code coverage configuration to get better output and verbosity when the tests are executed.

Could you please review?

cc: @johannaSommer

Related Issue

Fixes #228

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good to me! I have just one quick question on the markers :)

pyproject.toml Outdated
"src/pruna/tests",
]

markers = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case could we remove the markers from the conftest.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the markers need to be present in conftest.py that provide reusable setup/teardown logic for tests. We have defined the markers here to maintain a reference of all the markers available. We could remove them if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParagEkbote, should we remove markers from here? It would be difficult to maintain them in two different places.

Copy link
Contributor Author

@ParagEkbote ParagEkbote Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. @davidberenstein1957

I've removed them. Could you please review?

@johannaSommer johannaSommer self-requested a review July 8, 2025 12:06
@davidberenstein1957 davidberenstein1957 merged commit b2df539 into PrunaAI:main Jul 8, 2025
3 checks passed
@davidberenstein1957
Copy link
Member

@ParagEkbote thanks again for the lovely PR! They are really welcome :)

@ParagEkbote ParagEkbote deleted the add-pytest-and-test-coverage-configs branch July 8, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pytest configuration in pyproject.toml

3 participants