Merged
Conversation
…e and the improvement on top of regular torch compile is not very high
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
nifleisch
requested changes
Mar 28, 2025
Collaborator
nifleisch
left a comment
There was a problem hiding this comment.
PR looks good. There’s just one minor issue in the README that needs a small fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes onediff from pruna since it isn't well maintained anymore and the improvement on top of regular torch compile is not very high
Related Issue
Some users have experiences troubles installing pruna due to onediff
Type of Change
How Has This Been Tested?
Tests still pass.
Checklist
Additional Notes
None.