Skip to content

feat: remove onediff from pruna#40

Merged
johnrachwan123 merged 3 commits intomainfrom
feat/remove-onediff
Apr 1, 2025
Merged

feat: remove onediff from pruna#40
johnrachwan123 merged 3 commits intomainfrom
feat/remove-onediff

Conversation

@johnrachwan123
Copy link
Member

@johnrachwan123 johnrachwan123 commented Mar 27, 2025

Description

This PR removes onediff from pruna since it isn't well maintained anymore and the improvement on top of regular torch compile is not very high

Related Issue

Some users have experiences troubles installing pruna due to onediff

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tests still pass.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

…e and the improvement on top of regular torch compile is not very high
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@johannaSommer johannaSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rip onediff

@johannaSommer johannaSommer requested a review from nifleisch March 27, 2025 15:45
Copy link
Collaborator

@nifleisch nifleisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. There’s just one minor issue in the README that needs a small fix.

Copy link
Collaborator

@nifleisch nifleisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@johnrachwan123 johnrachwan123 merged commit e1d91b0 into main Apr 1, 2025
7 checks passed
@johnrachwan123 johnrachwan123 deleted the feat/remove-onediff branch April 1, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants