fix: python version compatibility and mypy issues#54
Merged
Conversation
johannaSommer
approved these changes
Apr 10, 2025
llcnt
approved these changes
Apr 10, 2025
Collaborator
llcnt
left a comment
There was a problem hiding this comment.
I re-ran some tests (no time to run them all unfortunately) just to be sure, and looks good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
transformers == 4.51introduced some mypy errors as referenced huggingface/transformers#37339Also addresses compatibility issues with Python <3.10 caused by the use of the
|(union) operator.Type of Change
Checklist