Skip to content

fix: drop outdated whisper-s2t#689

Merged
gsprochette merged 2 commits into
mainfrom
feat/drop-outdated-whisper-s2t
Jun 18, 2026
Merged

fix: drop outdated whisper-s2t#689
gsprochette merged 2 commits into
mainfrom
feat/drop-outdated-whisper-s2t

Conversation

@gsprochette

Copy link
Copy Markdown
Collaborator

Description

This PR drops support for whisper-s2t because the package this algorithm relies on is not maintained and is incompatible with recent transformers versions (even before 5.0.0).

Because whisper-s2t is dropped, the extra now containing only ctranslate2 is rename to something more telling: ctranslate

Related Issue

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (no functional change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

  • I added or updated tests covering my changes
  • Existing tests pass locally (uv run pytest -m "cpu and not slow")

For full setup and testing instructions, see the Contributing Guide.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code, especially for agent-assisted changes
  • I updated the documentation where necessary

Thanks for contributing to Pruna! We're excited to review your work.

New to contributing? Check out our Contributing Guide for everything you need to get started.

Note:

  • Draft PRs or PRs without a clear and detailed overview may be delayed.
  • Please mark your PR as Ready for Review and ensure the sections above are filled out.
  • Contributions that are entirely AI-generated without meaningful human review are discouraged.

@gsprochette gsprochette requested a review from begumcig June 18, 2026 07:55

@begumcig begumcig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye whisper!!!! thank you so much Gaspar

@gsprochette gsprochette merged commit 3f64e8e into main Jun 18, 2026
9 checks passed
@gsprochette gsprochette deleted the feat/drop-outdated-whisper-s2t branch June 18, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants