fix: switch torch_dynamic and quanto saves to save_before_apply#696
Merged
begumcig merged 3 commits intoJun 22, 2026
Merged
Conversation
begumcig
approved these changes
Jun 22, 2026
begumcig
left a comment
Member
There was a problem hiding this comment.
Thank you!!! looks super good to me! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In transformers 5, llama architectures are not picklable because of the choice of kernel functions.
Both quanto and torch_dynamic were facing saving problems, and are switched to save_before_apply to preserve compatibility with (among other) compilation algorithms (compilation algorithms use save_before_apply -> the quantized model's save functions is called -> for quanto or torch_dynamic that would be torch.save -> error).
Related Issue
Fixes #(issue number)
Type of Change
Testing
uv run pytest -m "cpu and not slow")For full setup and testing instructions, see the Contributing Guide.
Checklist
Thanks for contributing to Pruna! We're excited to review your work.
New to contributing? Check out our Contributing Guide for everything you need to get started.