refactor!: Make local_variables a dictionary instead of a list of strings#79
Merged
dexter2206 merged 9 commits intomainfrom Jul 12, 2024
Merged
refactor!: Make local_variables a dictionary instead of a list of strings#79dexter2206 merged 9 commits intomainfrom
dexter2206 merged 9 commits intomainfrom
Conversation
03c0d03 to
a2ffd95
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Konrad Jałowiecki.
|
6af5af7 to
b06f09b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we store local variables as a list of strings, each of them of the form "symbol = expression", e.g.:
However, each time such variables are processed, this lists of strings gets converted to a dictionary. Therefore, it is only natural to make
local_variablesa dictionary in the first place, so that the example above looks like:which is what this PR does.
While refactoring this, some functions became obsolete and were thus removed from the codebase entirely as a part of this PR.
Please verify that you have completed the following steps