Skip to content

[refactor] idd-implement/SKILL.md has CRLF line endings — trips git diff --check #95

@kiki830621

Description

@kiki830621

Problem

plugins/issue-driven-dev/skills/idd-implement/SKILL.md has CRLF line terminators throughout (632 CR characters; file reports "with CRLF line terminators"). The sibling skill files (idd-all, idd-verify, idd-all-chain SKILL.md, pr-flow.md) are LF.

When any line in this file is edited, git diff --check flags the touched line as trailing whitespace — the \r before \n reads as trailing whitespace. Observed on PR #94 (the #87/#74 auto-close-trap cluster): the reworded line 487 tripped git diff --check.

Type

refactor (file hygiene / line-ending normalization)

Impact

  • Cosmetic CI noise — any future edit to this file trips git diff --check on the touched line.
  • If CI ever runs git diff --check as a gate, edits to this file would fail it.
  • Inconsistent with the other IDD skill files (LF).

Suggested fix

Convert idd-implement/SKILL.md from CRLF to LF in a dedicated commit (dos2unix or sed). Whole-file change (~632 lines) so it must be its own commit/PR — bundling into a logic change makes the logic diff unreadable. Consider a .gitattributes entry (*.md text eol=lf) to prevent recurrence.

Source

Surfaced during /idd-verify --pr 94 R1 verify (Codex reviewer non-blocking note) — the #87/#74 auto-close-trap cluster. Deliberately kept out of PR #94's scope (a 632-line line-ending diff would dwarf the 4-line logic fix).

Related: #87, #74

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions