Profiling cleanup and optimized kernels#485
Merged
jsuarez5341 merged 12 commits intoPufferAI:4.0from Feb 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things.
First, we add a few composite training profiles. In profile_train.cu, trainforward looks at the forward, loss, and backwards and trainstep is a full end to end training step. And profile_rolloutcopy.cu profiles the data prepartaion (i.e. advantage computation, priority sampling, and select + copy).
You can also test both float32 and bf16 (using --precision=float or --precision=bf16)
Next we optimize the compute_advantage kernel (~2.25x), compute_prio (~2.5) code, and train_select_and_copy (~10x) code.
The main speed up in the compute advantage kernel comes from 128-bit loads.
The main speed up from the compute prio is fusing ops together into their own kernels.
the main speed up from the select and copy is fusing all the copies into a single kernel.
If you build and run: