Skip to content

PufferLib 4.0 macOS installation fixes#507

Open
daphne-cornelisse wants to merge 1 commit intoPufferAI:4.0from
daphne-cornelisse:macos
Open

PufferLib 4.0 macOS installation fixes#507
daphne-cornelisse wants to merge 1 commit intoPufferAI:4.0from
daphne-cornelisse:macos

Conversation

@daphne-cornelisse
Copy link
Copy Markdown
Contributor

A couple of fixes that allow me to run puffer on macOS

@PLAZMAMA
Copy link
Copy Markdown
Contributor

PLAZMAMA commented Apr 10, 2026

I'm trying this fix out and am running into some issues. Are you running this on an Intel or M mac?

@daphne-cornelisse
Copy link
Copy Markdown
Contributor Author

I'm trying this fix out and am running into some issues. Are you running this on an Intel or M mac?

Apple M5 chip

@PLAZMAMA
Copy link
Copy Markdown
Contributor

I'm trying this fix out and am running into some issues. Are you running this on an Intel or M mac?

Apple M5 chip

I have an M5 too, looks like the main issue was that I was running just ./build.sh breakout and ./build.sh breakout --cpu instead of ./build.sh breakout --local.

I actually was able fix this issue that stems from OpenMP gcc and llvm/clang linking differences.
Would you like me to upload the changes to this PR? (if so, you'll need to add me a collaborator in your fork)

@daphne-cornelisse
Copy link
Copy Markdown
Contributor Author

I'm trying this fix out and am running into some issues. Are you running this on an Intel or M mac?

Apple M5 chip

I have an M5 too, looks like the main issue was that I was running just ./build.sh breakout and ./build.sh breakout --cpu instead of ./build.sh breakout --local.

I actually was able fix this issue that stems from OpenMP gcc and llvm/clang linking differences. Would you like me to upload the changes to this PR? (if so, you'll need to add me a collaborator in your fork)

Maybe easiest to open a new PR to the puffer repo?

@PLAZMAMA
Copy link
Copy Markdown
Contributor

I'm trying this fix out and am running into some issues. Are you running this on an Intel or M mac?

Apple M5 chip

I have an M5 too, looks like the main issue was that I was running just ./build.sh breakout and ./build.sh breakout --cpu instead of ./build.sh breakout --local.
I actually was able fix this issue that stems from OpenMP gcc and llvm/clang linking differences. Would you like me to upload the changes to this PR? (if so, you'll need to add me a collaborator in your fork)

Maybe easiest to open a new PR to the puffer repo?

I ended up spend all of today digging into this issue more and found out that Joseph actually implemented your fix ~a week ago on 4.0. 😄

Also, I created a new PR #527 that improves this fix by addressing the real root cause of this issue which will end up saving a good amount of maintenance for mac in the future(hopefully).
When you have time, if you can check it out and let me know if it works on your mac that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants