Group Guide TOC and sync URL hash on click#310
Open
PunchTheDev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-rubric pass on Guide TOC against the 3 pillars. Groups the flat 12-item nav into Concepts · Onboarding · Reference so a first-timer sees the onboarding arc at a glance, adds per-item hover previews, and fixes the silent deep-link bug.
Teardown
preventDefault+scrollIntoViewbut never updated the URL hash → refresh/back-button/share-link all lost the position. Modifier keys (cmd/ctrl-click) couldn't open a section in a new tab.Changes
QuickstartGuide.tsxL271–425: replaceTOC_ITEMSflat array withTOC_GROUPS(Concepts · Onboarding · Reference) →TocItemcarries apreviewstring used astitle=tooltip (113–134 chars each).history.replaceStates the URL hash so refresh + back-button + share-link all round-trip. HonorsmetaKey/ctrlKey/shiftKey/altKeyso cmd/ctrl-click opens in a new tab via the browser default.Verification
Puppeteer 1440×900 on
/guide:groupHeadings: ["Concepts","Onboarding","Reference"],itemCount: 12API reference→ URL updates to/guide#api/guide#rewards→ scrollY=6000, scroll-spy marksHow rewards workactive