Clamp baseline geometry to build volume, cover load point Z#214
Merged
Conversation
Forge Eval — NEW LEADER 🏆Cross-Category Results
Composite score: 1629.3% of baseline across all 3 categories (lower = better; maximize metrics are inverted for uniform comparison) Beats SOTA in at least one category with sufficient margin. A maintainer will review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The baseline agent was failing CI on some specs because:
plate_y/plate_zwere computed as bolt-pattern max + 20mm margin, which exceeded the build volume on some specs (Y dimension errors).shelf_thicknesswas hardcoded to 12mm; specs whereload_point_mm[2]> 12mm had no material at the load point → "Too few nodes near load point" FEA failure.Changes
plate_y,plate_ztobuild_volume_mmY and Z limits.shelf_lengthtobuild_volume_mmX limit.shelf_thickness = max(15.0, load_pt[2] + 10.0), clamped tobuild_volume_mmZ — ensures the shelf has material at the load point for all spec geometries.